From 6512d5e89b6279209aa4351dccf98b905a640bf0 Mon Sep 17 00:00:00 2001 From: DrMaxNix Date: Fri, 8 Mar 2024 22:49:30 +0100 Subject: [PATCH] :bug: use default in case tree-view setting is unset --- README.md | 11 +++++++---- init-snippet.coffee | 4 +++- init-snippet.js | 4 +++- 3 files changed, 13 insertions(+), 6 deletions(-) diff --git a/README.md b/README.md index c1c588f..cac3e34 100644 --- a/README.md +++ b/README.md @@ -52,7 +52,9 @@ tryTreeViewClose = function(){ var treeViewHasProjects = (treeView.element.querySelector("ol.tree-view-root") != null); // close the tree-view dock when the `Hidden On Startup` setting is activated or when it is empty - if(atom.packages.config.settings["tree-view"].hiddenOnStartup || !treeViewHasProjects){ + let treeViewSettings = atom.packages.config.settings["tree-view"] ?? {}; + let hiddenOnStartup = treeViewSettings.hiddenOnStartup ?? false; + if(hiddenOnStartup || !treeViewHasProjects){ treeView.hide(); } @@ -82,7 +84,6 @@ atom.workspace.onDidOpen ({item}) -> tryTreeViewCloseInterval = setInterval(tryTreeViewClose, 100) - ## TRY TO CLOSE THE TREE-VIEW ## tryTreeViewClose = () -> # get tree-view element @@ -101,7 +102,9 @@ tryTreeViewClose = () -> treeViewHasProjects = (treeView.element.querySelector("ol.tree-view-root") != null) # close the tree-view dock when the `Hidden On Startup` setting is activated or when it is empty - if atom.packages.config.settings["tree-view"].hiddenOnStartup || !treeViewHasProjects + treeViewSettings = atom.packages.config.settings["tree-view"] ? {} + hiddenOnStartup = treeViewSettings.hiddenOnStartup ? false + if hiddenOnStartup || !treeViewHasProjects treeView.hide() # stop trying @@ -116,4 +119,4 @@ Now you can configure whether you want the tree-view to be hidden on startup in **Hidden On Startup: not checked**: Only hide tree-view on startup when it does not contain open projects -> Successfully tested using Pulsar v1.104.0 +> Successfully tested using Pulsar v1.114.0 diff --git a/init-snippet.coffee b/init-snippet.coffee index 65930cd..b14dc85 100644 --- a/init-snippet.coffee +++ b/init-snippet.coffee @@ -35,7 +35,9 @@ tryTreeViewClose = () -> treeViewHasProjects = (treeView.element.querySelector("ol.tree-view-root") != null) # close the tree-view dock when the `Hidden On Startup` setting is activated or when it is empty - if atom.packages.config.settings["tree-view"].hiddenOnStartup || !treeViewHasProjects + treeViewSettings = atom.packages.config.settings["tree-view"] ? {} + hiddenOnStartup = treeViewSettings.hiddenOnStartup ? false + if hiddenOnStartup || !treeViewHasProjects treeView.hide() # stop trying diff --git a/init-snippet.js b/init-snippet.js index 84891e1..9200474 100644 --- a/init-snippet.js +++ b/init-snippet.js @@ -37,7 +37,9 @@ tryTreeViewClose = function(){ var treeViewHasProjects = (treeView.element.querySelector("ol.tree-view-root") != null); // close the tree-view dock when the `Hidden On Startup` setting is activated or when it is empty - if(atom.packages.config.settings["tree-view"].hiddenOnStartup || !treeViewHasProjects){ + let treeViewSettings = atom.packages.config.settings["tree-view"] ?? {}; + let hiddenOnStartup = treeViewSettings.hiddenOnStartup ?? false; + if(hiddenOnStartup || !treeViewHasProjects){ treeView.hide(); }