From 0d46ac352302ba4b89d3c687aa24d29312b96407 Mon Sep 17 00:00:00 2001 From: David Allison <62114487+david-allison@users.noreply.github.com> Date: Tue, 5 Mar 2024 20:01:32 +0000 Subject: [PATCH] chore: guard against null `getExternalFilesDirs` I know `getExternalFilesDir(null)!!` can throw, I'm unsure if the array can throw, but it's best to be safe here --- AnkiDroid/src/main/java/com/ichi2/anki/CollectionHelper.kt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/AnkiDroid/src/main/java/com/ichi2/anki/CollectionHelper.kt b/AnkiDroid/src/main/java/com/ichi2/anki/CollectionHelper.kt index 92414ed849..c04baf0645 100644 --- a/AnkiDroid/src/main/java/com/ichi2/anki/CollectionHelper.kt +++ b/AnkiDroid/src/main/java/com/ichi2/anki/CollectionHelper.kt @@ -230,7 +230,7 @@ object CollectionHelper { * @see android.content.Context.getExternalFilesDirs */ fun getAppSpecificExternalDirectories(context: Context): List { - return context.getExternalFilesDirs(null).filterNotNull() + return context.getExternalFilesDirs(null)?.filterNotNull() ?: listOf() } /**