mirror of
https://github.com/ankidroid/Anki-Android.git
synced 2024-09-20 03:52:15 +02:00
style(lint, Timber): lint issues with Timber solved in current release
remove lint rule ignore, remove comments, fix up entropic lint violations that crept in while lint rules were disabled
This commit is contained in:
parent
4e49541712
commit
0d9df62371
@ -308,7 +308,6 @@ dependencies {
|
|||||||
implementation 'net.mikehardy:google-analytics-java7:2.0.13'
|
implementation 'net.mikehardy:google-analytics-java7:2.0.13'
|
||||||
implementation 'com.squareup.okhttp3:okhttp:4.9.2'
|
implementation 'com.squareup.okhttp3:okhttp:4.9.2'
|
||||||
implementation 'com.arcao:slf4j-timber:3.1'
|
implementation 'com.arcao:slf4j-timber:3.1'
|
||||||
// TODO: Re-enable Timber inspections in lint-release.xml after https://github.com/JakeWharton/timber/issues/408
|
|
||||||
implementation 'com.jakewharton.timber:timber:5.0.1'
|
implementation 'com.jakewharton.timber:timber:5.0.1'
|
||||||
implementation 'org.jsoup:jsoup:1.14.3'
|
implementation 'org.jsoup:jsoup:1.14.3'
|
||||||
implementation "com.github.zafarkhaja:java-semver:0.9.0" // For AnkiDroid JS API Versioning
|
implementation "com.github.zafarkhaja:java-semver:0.9.0" // For AnkiDroid JS API Versioning
|
||||||
|
@ -22,6 +22,8 @@ import android.content.pm.PackageManager;
|
|||||||
import android.content.pm.ResolveInfo;
|
import android.content.pm.ResolveInfo;
|
||||||
import android.net.Uri;
|
import android.net.Uri;
|
||||||
import androidx.browser.customtabs.CustomTabsService;
|
import androidx.browser.customtabs.CustomTabsService;
|
||||||
|
import timber.log.Timber;
|
||||||
|
|
||||||
import android.text.TextUtils;
|
import android.text.TextUtils;
|
||||||
import android.util.Log;
|
import android.util.Log;
|
||||||
|
|
||||||
@ -128,7 +130,7 @@ public class CustomTabsHelper {
|
|||||||
return true;
|
return true;
|
||||||
}
|
}
|
||||||
} catch (RuntimeException e) {
|
} catch (RuntimeException e) {
|
||||||
Log.e(TAG, "Runtime exception while getting specialized handlers");
|
Timber.e("Runtime exception while getting specialized handlers");
|
||||||
}
|
}
|
||||||
return false;
|
return false;
|
||||||
}
|
}
|
||||||
|
@ -490,7 +490,7 @@ public class AdvancedStatistics {
|
|||||||
|
|
||||||
public Deck createDeck(long did, DeckManager decks) {
|
public Deck createDeck(long did, DeckManager decks) {
|
||||||
|
|
||||||
Timber.d("Trying to get deck settings for deck with id=" + did);
|
Timber.d("Trying to get deck settings for deck with id=%s", did);
|
||||||
|
|
||||||
DeckConfig conf = decks.confForDid(did);
|
DeckConfig conf = decks.confForDid(did);
|
||||||
|
|
||||||
|
@ -55,16 +55,6 @@
|
|||||||
|
|
||||||
<!-- Allows Timber issues defined for AnkiDroid without an api dependency on Timber -->
|
<!-- Allows Timber issues defined for AnkiDroid without an api dependency on Timber -->
|
||||||
<issue id="UnknownIssueId" severity="ignore" />
|
<issue id="UnknownIssueId" severity="ignore" />
|
||||||
<!-- This come from Timber and we need to also ignore them -->
|
|
||||||
<!-- Ignored due to https://github.com/JakeWharton/timber/issues/408 -->
|
|
||||||
<issue id="BinaryOperationInTimber" severity="ignore" />
|
|
||||||
<issue id="LogNotTimber" severity="ignore" />
|
|
||||||
<issue id="StringFormatInTimber" severity="ignore" />
|
|
||||||
<issue id="ThrowableNotAtBeginning" severity="ignore" />
|
|
||||||
<issue id="TimberArgCount" severity="ignore" />
|
|
||||||
<issue id="TimberArgTypes" severity="ignore" />
|
|
||||||
<issue id="TimberTagLength" severity="ignore" />
|
|
||||||
<issue id="TimberExceptionLogging" severity="ignore" />
|
|
||||||
|
|
||||||
<issue id="UseCompatTextViewDrawableXml" severity="ignore" />
|
<issue id="UseCompatTextViewDrawableXml" severity="ignore" />
|
||||||
<issue id="AcceptsUserCertificates" severity="ignore" />
|
<issue id="AcceptsUserCertificates" severity="ignore" />
|
||||||
|
Loading…
Reference in New Issue
Block a user