mirror/Anki-Android
0
0
Fork 0
mirror of https://github.com/ankidroid/Anki-Android.git synced 2024-09-20 12:02:16 +02:00
Code

Duplicate CrowdIn Strings: Cleanup

Browse Source 
Kill some dead code, and add quotes for console output.

Related: 7582
This commit is contained in:
David Allison 2020-11-12 06:41:46 +00:00 committed by Mike Hardy
parent 1eab35e040
commit 1543f0f900
1 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
lint-rules/src/main/java/com/ichi2/anki/lint/rules/DuplicateCrowdInStrings.java
View File

@ -197,12 +197,6 @@ public class DuplicateCrowdInStrings extends ResourceXmlDetector {
prevLocation = location;
prevString = string;
}
// Was in the Kotlin - but marked as unreachable - maybe a bug?
/*
if (firstLocation == null) {
continue;
}
*/
List<String> nameValues = new ArrayList<>();
for (String name : names) {
@ -211,7 +205,8 @@ public class DuplicateCrowdInStrings extends ResourceXmlDetector {
String nameList = LintUtils.formatList(nameValues, nameValues.size(),true);
String message = String.format("Duplicate string value `%s`, used in %s", prevString, nameList);
// we use both quotes and code styling here so it appears in the console quoted
String message = String.format("Duplicate string value \"`%s`\", used in %s", prevString, nameList);
if (caseVaries) {
message += ". Use `android:inputType` or `android:capitalize` " +
"to treat these as the same and avoid string duplication.";