mirror/Anki-Android
0
0
Fork 0
mirror of https://github.com/ankidroid/Anki-Android.git synced 2024-09-20 12:02:16 +02:00
Code

refactor(preferences): updateSummary nullability

Browse Source
This commit is contained in:
David Allison 2022-03-08 18:39:46 +00:00 committed by Mike Hardy
parent b69339bbbc
commit 15818fc56c
1 changed files with 8 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
AnkiDroid/src/main/java/com/ichi2/anki/Preferences.kt
View File

@ -266,7 +266,6 @@ class Preferences : AnkiActivity() {
listpref.summary = listpref.entry.toString()
}
@KotlinCleanup("make value non-null")
private fun updateSummary(pref: Preference?) {
if (pref == null || pref.key == null) {
return
@ -289,19 +288,15 @@ class Preferences : AnkiActivity() {
}
}
// Get value text
val value: String? = try {
when (pref) {
is NumberRangePreferenceCompat -> pref.getValue().toString()
is SeekBarPreferenceCompat -> pref.value.toString()
is ListPreference -> pref.entry.toString()
is EditTextPreference -> pref.text
is ControlPreference -> return
else -> return
}
} catch (e: NullPointerException) {
Timber.w(e)
""
val value: String = when (pref) {
is NumberRangePreferenceCompat -> pref.getValue().toString()
is SeekBarPreferenceCompat -> pref.value.toString()
is ListPreference -> pref.entry?.toString() ?: ""
is EditTextPreference -> pref.text ?: ""
is ControlPreference -> return
else -> return
}
// Get summary text
val oldSummary = mOriginalSummaries[pref.key]
// Replace summary text with value according to some rules