mirror/Anki-Android
0
0
Fork 0
mirror of https://github.com/ankidroid/Anki-Android.git synced 2024-09-19 19:42:17 +02:00
Code

tests: standardize activity cleanup

Browse Source 
`startActivityNormallyOpenCollectionWithIntent` calls
`saveControllerForCleanup`, previously:

**DeckPickerWidgetConfigTest**
Did not perform cleanup

**CardAnalysisWidgetConfigTest**
Manually performed cleanup

This may fix Issue 17010: `testLoadSavedPreferences` was flaky
This commit is contained in:
David Allison 2024-09-18 16:36:34 +01:00
parent a43c66cc4e
commit 43262eafef
2 changed files with 2 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
AnkiDroid/src/test/java/com/ichi2/anki/widget/cardanalysis/CardAnalysisWidgetConfigTest.kt
View File

@ -28,7 +28,6 @@ import com.ichi2.widget.cardanalysis.CardAnalysisWidgetConfig
import com.ichi2.widget.cardanalysis.CardAnalysisWidgetPreferences
import org.hamcrest.MatcherAssert.assertThat
import org.hamcrest.Matchers.equalTo
import org.junit.After
import org.junit.Before
import org.junit.Test
import org.junit.runner.RunWith
@ -53,22 +52,12 @@ class CardAnalysisWidgetConfigTest : RobolectricTest() {
putExtra(AppWidgetManager.EXTRA_APPWIDGET_ID, 1)
}
activity = Robolectric.buildActivity(CardAnalysisWidgetConfig::class.java, intent)
.create()
.start()
.resume()
.get()
activity = startActivityNormallyOpenCollectionWithIntent(CardAnalysisWidgetConfig::class.java, intent)
// Ensure deckAdapter is initialized
activity.initializeUIComponents()
}
@After
override fun tearDown() {
super.tearDown()
activity.finish()
}
/**
* Tests the functionality of saving selected decks to preferences.
*

6
AnkiDroid/src/test/java/com/ichi2/anki/widget/deckpicker/DeckPickerWidgetConfigTest.kt
View File

@ -52,11 +52,7 @@ class DeckPickerWidgetConfigTest : RobolectricTest() {
putExtra(AppWidgetManager.EXTRA_APPWIDGET_ID, 1)
}
activity = Robolectric.buildActivity(DeckPickerWidgetConfig::class.java, intent)
.create()
.start()
.resume()
.get()
activity = startActivityNormallyOpenCollectionWithIntent(DeckPickerWidgetConfig::class.java, intent)
// Ensure deckAdapter is initialized
activity.initializeUIComponents()