mirror/Anki-Android
0
0
Fork 0
mirror of https://github.com/ankidroid/Anki-Android.git synced 2024-09-20 12:02:16 +02:00
Code

Duplicate CrowdIn Strings: Ignore translated

Browse Source 
We only want to check and warn for duplicates in our new strings

Related: 7582
This commit is contained in:
David Allison 2020-11-12 06:17:14 +00:00 committed by Mike Hardy
parent 60b7c8ec1d
commit 4c140c6f24
2 changed files with 20 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lint-rules/src/main/java/com/ichi2/anki/lint/rules/DuplicateCrowdInStrings.java
View File

@ -112,6 +112,11 @@ public class DuplicateCrowdInStrings extends ResourceXmlDetector {
@Override @Override
public void visitElement(@NotNull XmlContext context, @NotNull Element element) { public void visitElement(@NotNull XmlContext context, @NotNull Element element) {
// Only check the golden copy - not the translated sources.
if (!"values".equals(context.file.getParentFile().getName())) {
return;
}
NodeList childNodes = element.getChildNodes(); NodeList childNodes = element.getChildNodes();
if (childNodes.getLength() > 0) { if (childNodes.getLength() > 0) {
if (childNodes.getLength() == 1) { if (childNodes.getLength() == 1) {

17
lint-rules/src/test/java/com/ichi2/anki/lint/rules/DuplicateCrowdInStringsTest.java
View File

@ -26,7 +26,7 @@ public class DuplicateCrowdInStringsTest {
/** Easiest test case: Two exact duplicates in the same file */ /** Easiest test case: Two exact duplicates in the same file */
@Language("XML") @Language("XML")
private final String selfInvalid = "<resources>\n" + private final String mSelfInvalid = "<resources>\n" +
" <string name=\"hello\">a</string>\n" + " <string name=\"hello\">a</string>\n" +
" <string name=\"hello2\">a</string>\n" + " <string name=\"hello2\">a</string>\n" +
"</resources>"; "</resources>";
@ -38,9 +38,22 @@ public class DuplicateCrowdInStringsTest {
lint() lint()
.allowMissingSdk() .allowMissingSdk()
.allowCompilationErrors() .allowCompilationErrors()
.files(xml("res/values/string.xml", selfInvalid)) .files(xml("res/values/string.xml", mSelfInvalid))
.issues(DuplicateCrowdInStrings.ISSUE) .issues(DuplicateCrowdInStrings.ISSUE)
.run() .run()
.expectErrorCount(1); .expectErrorCount(1);
} }
@Test
public void invalidStringInNonEnglishPasses() {
// We only want to check the base resource files, not the translated ones -
// translators know if values are equivalent and do not require a comment explaining why.
lint()
.allowMissingSdk()
.allowCompilationErrors()
.files(xml("res/values-af/string.xml", mSelfInvalid))
.issues(DuplicateCrowdInStrings.ISSUE)
.run()
.expectErrorCount(0);
}
} }