mirror/Anki-Android
0
0
Fork 0
mirror of https://github.com/ankidroid/Anki-Android.git synced 2024-09-20 20:03:05 +02:00
Code

ensure that mTextView is not null

Browse Source 
After installing a new version of ankidroid from master and syncing, I got the message

```
    java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.Object java.lang.ref.WeakReference.get()' on a null object reference
        at com.ichi2.anki.stats.AnkiStatsTaskHandler$DeckPreviewStatistics.onPostExecute(AnkiStatsTaskHandler.java:275)
        at com.ichi2.anki.stats.AnkiStatsTaskHandler$DeckPreviewStatistics.onPostExecute(AnkiStatsTaskHandler.java:220)
        at android.os.AsyncTask.finish(AsyncTask.java:755)
        at android.os.AsyncTask.access$900(AsyncTask.java:192)
        at android.os.AsyncTask$InternalHandler.handleMessage(AsyncTask.java:772)
        at android.os.Handler.dispatchMessage(Handler.java:107)
        at android.os.Looper.loop(Looper.java:237)
        at android.app.ActivityThread.main(ActivityThread.java:8107)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:496)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1100)
```

I suspect that it is because collection or the db is empty (normal after a sync. )
This commit is contained in:
Arthur Milchior 2021-04-15 22:42:00 +02:00 committed by Mike Hardy
parent e2936c33e5
commit 6b0117bb3e
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
AnkiDroid/src/main/java/com/ichi2/anki/stats/AnkiStatsTaskHandler.java
View File

@ -233,6 +233,10 @@ public class AnkiStatsTaskHandler {
sLock.lock();
try {
Collection collection = params[0].first;
TextView textView = params[0].second;
mTextView = new WeakReference<>(textView);
if (!mIsRunning || collection == null || collection.getDb() == null) {
Timber.d("Quitting DeckPreviewStatistics before execution");
return null;
@ -240,9 +244,6 @@ public class AnkiStatsTaskHandler {
Timber.d("Starting DeckPreviewStatistics");
}
TextView textView = params[0].second;
mTextView = new WeakReference<>(textView);
//eventually put this in Stats (in desktop it is not though)
int cards;
int minutes;