From 7a4dfd093db8cc794b6f8b5f63e9f0a846b58985 Mon Sep 17 00:00:00 2001 From: Neel Doshi Date: Sun, 31 Mar 2024 06:45:05 +0530 Subject: [PATCH] Statistics uses xml from statistic.xml instead of page_fragment.xml Refactor : Code Improvement FIX :Correct AppBar Small Bug --- .../java/com/ichi2/anki/pages/Statistics.kt | 11 +++++- AnkiDroid/src/main/res/layout/statistics.xml | 35 +++++++++++++++++++ 2 files changed, 45 insertions(+), 1 deletion(-) create mode 100644 AnkiDroid/src/main/res/layout/statistics.xml diff --git a/AnkiDroid/src/main/java/com/ichi2/anki/pages/Statistics.kt b/AnkiDroid/src/main/java/com/ichi2/anki/pages/Statistics.kt index 1d6107b3ef..a5ed323c43 100644 --- a/AnkiDroid/src/main/java/com/ichi2/anki/pages/Statistics.kt +++ b/AnkiDroid/src/main/java/com/ichi2/anki/pages/Statistics.kt @@ -20,7 +20,9 @@ import android.content.Intent import android.os.Bundle import android.print.PrintAttributes import android.print.PrintManager +import android.view.LayoutInflater import android.view.View +import android.view.ViewGroup import androidx.core.content.ContextCompat.getSystemService import com.google.android.material.appbar.MaterialToolbar import com.ichi2.anki.CollectionManager @@ -34,10 +36,17 @@ class Statistics : PageFragment() { get() = resources.getString(R.string.statistics) override val pageName = "graphs" + override fun onCreateView( + inflater: LayoutInflater, + container: ViewGroup?, + savedInstanceState: Bundle? + ): View? { + return inflater.inflate(R.layout.statistics, container, false) + } override fun onViewCreated(view: View, savedInstanceState: Bundle?) { super.onViewCreated(view, savedInstanceState) - view.findViewById(R.id.toolbar)?.apply { + view.findViewById(R.id.toolbar).apply { inflateMenu(R.menu.statistics) menu.findItem(R.id.action_export_stats).title = CollectionManager.TR.statisticsSavePdf() setOnMenuItemClickListener { item -> diff --git a/AnkiDroid/src/main/res/layout/statistics.xml b/AnkiDroid/src/main/res/layout/statistics.xml new file mode 100644 index 0000000000..adb39e7d72 --- /dev/null +++ b/AnkiDroid/src/main/res/layout/statistics.xml @@ -0,0 +1,35 @@ + + + + + + + + + + + + + \ No newline at end of file