The actual github label that gets added to a PR with strings changes
is "Strings".
Note: also removed a checkout step for one of the jobs which is not
needed as we do the work through the github api.
When I bumped the e2e and unit test github runners to 21 I did not
also bump the jitpack build, but I believe it is best to have them
all using the same build toolchain
cache is corrupt on both macOS and Ubuntu. Disable it so CI works again
follow-on from 6768519cbb
issue:
```
* What went wrong:
Execution failed for task ':AnkiDroid:testPlayDebugUnitTest'.
> A build operation failed.
Immutable workspace contents have been modified: /home/runner/.gradle/caches/transforms-4/f46cf63d0a549c8bc814e25133f449eb. These workspace directories are not supposed to be modified once they are created. Deleting the directory in question can allow the content to be recreated.
> Immutable workspace contents have been modified: /home/runner/.gradle/caches/transforms-4/f46cf63d0a549c8bc814e25133f449eb. These workspace directories are not supposed to be modified once they are created. Deleting the directory in question can allow the content to be recreated.
```
error code 422 does not seem to be matching as the workflow
is finishing with an error when the PR exists
I would prefer it to finish cleanly even if the PR exists so I want
to see what the error is
this may hopefully be reverted in the future but right now there
are persistent cache corruption issues with gradle caching on windows
involving part of immutable cache being mutated
the new public runners have nested virt, and our emulator runner not
only should run well on it, they document to do exactly the changes
I did here before reading their documentation ;-)
the npm package ecosystem releases all the time and it clutters up the
PR queue for mostly meaningless dependency updates
dependabot has a new "groups" feature to group dependency update PRs
together in to one PR based on either name globs, update types, or
dependency type
this should allow us to get all non-breaking changes through in single
PRs, while breaking (semver-major) changes will get individual PRs for
more detailed consideration
https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#groups
* chore(i18n): switch sync translations workflow to ubuntu from macos
our i18n infrastructure used to rely on some macOS-specific behavior,
but now that it is all javascript I don't think the runner OS actually
matters
if it does not matter, then ubuntu is preferred as macos has limited
concurrency on free accounts
* build(deps, i18n): bump all javascript dependencies
they're all minors and/or patches so nothing special
closes out all the dependabot issues for javascript deps at once
these are an attempt at a "ci usage optimization", to avoid running
CI checks where they would not really matter
however, they have the side effect of not running CI checks all the time
we want them to (like, when we do i18n_sync...) so I want to simplify our
CI config and get i18n_sync running CI automatically
* Init Project
* upload tranlation source files to crowdin
* build, download and extract i18n files
* convert update function to ts
* fix regex, string replacement
* fix for translation of markettitle
* index for running upload, download, update
* upload, download, update using workflows
* Update sync_translations.yml
fix env config
cd to project dir
* revert username and email in git
* fix anyError condition check
* fix env and update project id
* refactor, add comments, extract constant
fix: market title string upload
create temp dir
* added comments, find broken strings before commit
- added docs
- added return type for functions
- better message for uploading, download, building and downloading
- find broken strings before commit
* add prettier
* add eslint
* remove find broken strings
* wait for zip build on crowdin server
* check broken strings
* use only non positional strings in test
* test string format errors
* check errors for float
* test: remove typescript string format checker and associated jest test
it duplicates android lint at great cost in dev time and run time
* chore: consolidate credential prep workflow steps
* style: `yarn install` is equivalent to `yarn`, just call `yarn`
* perf: avoid shell glob and add whole res folder
the only stages that should be changed are translation ones, so
we can let git do the expansion internally, which will avoid
shell-globbing which can have perf issues and/or fail if it matches
too many files
* style(lint): result of `yarn format` auto-formatting run
* style(lint): buildProgress var never reassigned, use const
* build(deps): result of `yarn upgrade --latest`
* fix: use new crowdin personal access token
this was freshly generated and added to github org under same name
* fix: use official project id
* style: progress output more condensed
* dev: use `tsc --watch` for dev command
this gives us continuous incremental build
* style: use exact header as in current file to minimize diff
we may decide to update this later, but this is important during
i18n sync process change to make sure diff is minimal
* fix: ignore 12-dont-translate files
these do not need to be copied from the zip to the app res directories
* fix: marketing title is created fresh each time
appending without clearing it out means it will grow infinitely
* docs: update comment on language list to match updated python version
this was changed in python while new system was in development,
synchronizing change here
* docs: simple comments on upload process
* add readme
* docs(l10n): expand the readme, reformat, use conventional all-caps README
* fix: ingest PR review feedback, prepare for final merge
- use numerical separator
- update comment about language tags (2- vs 3-letter etc)
- typos and formatting
- mark package as non-publishable ("private")
---------
Co-authored-by: Mike Hardy <github@mikehardy.net>
* build(deps): ignore commons-compress below 1.25 now
We are still not minSdkVersion >= API26 so we may not advance this
dependency yet, we just notch this forward one version at a time
so we continue to be aware of their releases, but ignore them for now
* build(deps): bump androidx.annotation:annotation from 1.6.0 to 1.7.0
Bumps androidx.annotation:annotation from 1.6.0 to 1.7.0.
---
updated-dependencies:
- dependency-name: androidx.annotation:annotation
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
* build(deps): bump com.google.protobuf:protobuf-kotlin-lite
Bumps com.google.protobuf:protobuf-kotlin-lite from 3.24.2 to 3.24.3.
---
updated-dependencies:
- dependency-name: com.google.protobuf:protobuf-kotlin-lite
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
* build(deps): bump org.jlleitschuh.gradle.ktlint from 11.5.1 to 11.6.0
Bumps org.jlleitschuh.gradle.ktlint from 11.5.1 to 11.6.0.
---
updated-dependencies:
- dependency-name: org.jlleitschuh.gradle.ktlint
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
* build(deps): bump com.google.protobuf:protobuf-kotlin-lite
Bumps com.google.protobuf:protobuf-kotlin-lite from 3.24.3 to 3.24.4.
---
updated-dependencies:
- dependency-name: com.google.protobuf:protobuf-kotlin-lite
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
* build(deps): bump commons-io:commons-io from 2.13.0 to 2.14.0
Bumps commons-io:commons-io from 2.13.0 to 2.14.0.
---
updated-dependencies:
- dependency-name: commons-io:commons-io
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
* build(deps): bump io.mockk:mockk from 1.13.7 to 1.13.8
Bumps [io.mockk:mockk](https://github.com/mockk/mockk) from 1.13.7 to 1.13.8.
- [Release notes](https://github.com/mockk/mockk/releases)
- [Commits](https://github.com/mockk/mockk/compare/1.13.7...1.13.8)
---
updated-dependencies:
- dependency-name: io.mockk:mockk
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
* Update Gradle Wrapper from 8.3 to 8.4.
Signed-off-by: gradle-update-robot <gradle-update-robot@regolo.cc>
* Only split APK build by ABI in release builds
This avoids the upstream android gradle plugin issue introduced in
AGPv8.1.2 (and seemingly fixed in AGBv8.3.0-alpha07) where doing
an ABI split while including resources crashes the build:
https://issuetracker.google.com/issues/302961829
If this causes problems or is distasteful, can be reverted when
AGP v8.3+ is adopted, or if they do pick it to AGPv8.2+, at that time
* Adopt android gradle plugin v8.1.2
* ignore dynamic receiver registrations without export-type specified
these receivers *should* specify at registration whether they are for export
or not for export but if that is added (such as in PR 14158) then there is also
a need to add a new permission to the manifest or you get runtime errors, and
we haven't figured that out yet
* build(deps): bump org.jetbrains.dokka from 1.9.0 to 1.9.10
Bumps [org.jetbrains.dokka](https://github.com/Kotlin/dokka) from 1.9.0 to 1.9.10.
- [Release notes](https://github.com/Kotlin/dokka/releases)
- [Commits](https://github.com/Kotlin/dokka/compare/v1.9.0...v1.9.10)
---
updated-dependencies:
- dependency-name: org.jetbrains.dokka
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
* build(deps): bump com.squareup.okhttp3:okhttp from 4.11.0 to 4.12.0
Bumps [com.squareup.okhttp3:okhttp](https://github.com/square/okhttp) from 4.11.0 to 4.12.0.
- [Changelog](https://github.com/square/okhttp/blob/master/CHANGELOG.md)
- [Commits](https://github.com/square/okhttp/compare/parent-4.11.0...parent-4.12.0)
---
updated-dependencies:
- dependency-name: com.squareup.okhttp3:okhttp
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
* build(deps): bump org.jlleitschuh.gradle.ktlint from 11.6.0 to 11.6.1
Bumps org.jlleitschuh.gradle.ktlint from 11.6.0 to 11.6.1.
---
updated-dependencies:
- dependency-name: org.jlleitschuh.gradle.ktlint
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
* Bump compileSdk to 34, handle new deprecations (#14556)
* Bump compileSdk to 34
* Alter system API overrides to handle newly nullable items in API34
Investigating the various changes led me to conclude that simple null
checks and default returns if null was an adequate response to the
newly-possible null case in the various parameters
* API34 deprecates Class.newInstance, get ctor and newInstance that instead
* use new API34 pixel calc style if available
this apparently allows for finer more dynamic user text sizing
* Temporarily suppress deprecation on animation overrides
API34 adds new predictive back behavior, which implies that the
transition animation overrides for activity stack change animations
now need to know whether the animation override is for activity open or
close, whereas we override both as a unit without thought
This needs a solution before the deprecated methods go away, likely in
the form of plumbing through (via a new parameter) the idea of whether
the call site intended to override open, close, or both animations. For
backwards compatibility this will likely need to be a Compat interface
(or interfaces) to replace the current implementation
* build(deps): bump androidx.webkit:webkit from 1.7.0 to 1.8.0
Bumps androidx.webkit:webkit from 1.7.0 to 1.8.0.
---
updated-dependencies:
- dependency-name: androidx.webkit:webkit
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
* build(deps): bump androidx.browser:browser from 1.5.0 to 1.6.0
Bumps androidx.browser:browser from 1.5.0 to 1.6.0.
---
updated-dependencies:
- dependency-name: androidx.browser:browser
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
* build(deps): bump androidx.activity:activity-ktx from 1.7.2 to 1.8.0 (#14515)
* build(deps): bump androidx.activity:activity-ktx from 1.7.2 to 1.8.0
Bumps androidx.activity:activity-ktx from 1.7.2 to 1.8.0.
---
updated-dependencies:
- dependency-name: androidx.activity:activity-ktx
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
* call super.onBackPressed in onBackPressed overrides
This is more "predictive back" feature fallout, this commit should be examined,
and the behavior in these 4 objects may need a change, in order to more correctly
deal with API34 predictive back
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Mike Hardy <github@mikehardy.net>
* build(deps): bump androidx.recyclerview:recyclerview from 1.3.1 to 1.3.2
Bumps androidx.recyclerview:recyclerview from 1.3.1 to 1.3.2.
---
updated-dependencies:
- dependency-name: androidx.recyclerview:recyclerview
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
* build(deps): bump androidx.core:core-ktx from 1.10.1 to 1.12.0 (#14407)
* build(deps): bump androidx.core:core-ktx from 1.10.1 to 1.12.0
Bumps androidx.core:core-ktx from 1.10.1 to 1.12.0.
---
updated-dependencies:
- dependency-name: androidx.core:core-ktx
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
* PendingIntentCompat.getBroadcast() is nullable now, wrap use of result in null checks
It will only return null if we specify intent flags which we never specify, so our behavior
does not need to change, but we must respect the type system by wrapping the use of the now-nullable
result in null checks
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Mike Hardy <github@mikehardy.net>
* build(deps): bump androidx.sqlite:sqlite-framework from 2.3.1 to 2.4.0
Bumps androidx.sqlite:sqlite-framework from 2.3.1 to 2.4.0.
---
updated-dependencies:
- dependency-name: androidx.sqlite:sqlite-framework
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
* build(deps): bump androidx.appcompat:appcompat
Bumps androidx.appcompat:appcompat from 1.7.0-alpha02 to 1.7.0-alpha03.
---
updated-dependencies:
- dependency-name: androidx.appcompat:appcompat
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
---------
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: gradle-update-robot <gradle-update-robot@regolo.cc>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: gradle-update-robot <gradle-update-robot@regolo.cc>
