0
0
mirror of https://github.com/ankidroid/Anki-Android.git synced 2024-09-20 12:02:16 +02:00
Commit Graph

6610 Commits

Author SHA1 Message Date
codingtosh
0de8204f72 [Kotlin Migration] WebViewDebugging
Package: com.ichi2.utils
2021-11-10 14:57:00 -05:00
codingtosh
2e09f32fa8 Rename WebViewDebugging.java to WebViewDebugging.kt
Package: com.ichi2.utils
2021-11-10 14:57:00 -05:00
codingtosh
64e194d2e2 [Kotlin Migration] SystemContextMenu
Package: com.ichi2.anki.contextmenu
2021-11-10 14:56:23 -05:00
codingtosh
16035325b1 Rename SystemContextMenu.java to SystemContextMenu.kt
Package: com.ichi2.anki.contextmenu
2021-11-10 14:56:23 -05:00
Mani
c8cbb0b5b2 change class to object and val to const val 2021-11-10 14:55:42 -05:00
Mani
167cc4d049 rfc standard email 2021-11-10 14:55:42 -05:00
Mani
e977f4a7b0 test bury and suspend card before calling using js api similar to toggle flag and mark card 2021-11-10 14:55:42 -05:00
Mani
b3624fe0eb check mark card and toggle flag using extracted function 2021-11-10 14:55:42 -05:00
Mani
f1bcdb55b1 created new class for JS API Constant and extracted api check to function 2021-11-10 14:55:42 -05:00
codingtosh
d097160ff3 [Kotlin Migration] DatabaseLock
Package: com.ichi2.anki.debug
2021-11-10 14:54:27 -05:00
codingtosh
210acabfc8 Rename DatabaseLock.java to DatabaseLock.kt
Package: com.ichi2.anki.debug
2021-11-10 14:54:27 -05:00
Piyush Goel
b1a8b5644f Migrated CreateDeckDialogTest to kotlin. 2021-11-10 07:29:47 -05:00
Piyush Goel
a2c380f2e9 Renamed CreateDeckDialogTest.java to CreateDeckDialogTest.kt 2021-11-10 07:29:47 -05:00
David Allison
6cbe2cb499 refactor: remove FunctionalInterfaces.Function
This is handled by desugaring, replaced with java.util.function.Function
2021-11-10 07:29:11 -05:00
David Allison
e599145b41 refactor: remove FunctionalInterfaces.Consumer
This is handled by desugaring, replaced with java.util.function.Consumer
2021-11-10 07:29:11 -05:00
David Allison
1752855177 refactor: "Consumer" interface method rename
accept is what the SDK version is called
2021-11-10 07:29:11 -05:00
David Allison
6a47d0fd85 refactor: remove FunctionalInterfaces.Supplier
This is handled by desugaring, replaced with java.util.function.Supplier
2021-11-10 07:29:11 -05:00
Piyush Goel
25b95dcad6 Migrated ModelFieldEditorTest to kotlin. 2021-11-09 13:24:58 -05:00
Piyush Goel
dafc30e6bf Renamed ModelFieldEditorTest.java to ModelFieldEditorTest.kt 2021-11-09 13:24:58 -05:00
Piyush Goel
128d6fdf75 Migrated InsertFieldDialogFactory to kotlin 2021-11-09 13:24:09 -05:00
Piyush Goel
9f36abb011 Renamed InsertFieldDialogFactory.java to InsertFieldDialogFactory.kt 2021-11-09 13:24:09 -05:00
Piyush Goel
46cdd77470 Migrated CustomStudyDialogTest to kotlin. 2021-11-09 13:23:12 -05:00
Piyush Goel
8ce0e32b4b Renamed CustomStudyDialogTest.java to CustomStudyDialogTest.kt 2021-11-09 13:23:12 -05:00
codingtosh
b756d269df [Kotlin Migration] MethodLogger
Package: com.ichi2.utils
2021-11-09 10:00:08 -05:00
codingtosh
626696169e Rename MethodLogger.java to MethodLogger.kt
Package: com.ichi2.utils
2021-11-09 10:00:08 -05:00
Piyush Goel
6fd41ae687 Migrated DatabaseErrorDialog to kotlin. 2021-11-09 09:59:28 -05:00
Piyush Goel
f02d966702 Renamed DatabaseErrorDialog.java to DatabaseErrorDialog.kt 2021-11-09 09:59:28 -05:00
Piyush Goel
190c230f0d Migrated DeckSelectionDialog to kotlin 2021-11-09 14:39:50 +00:00
Piyush Goel
1a0b20401f Renamed DeckSelectionDialog.java to DeckSelectionDialog.kt 2021-11-09 14:39:50 +00:00
codingtosh
95bf2bd060 [Kotlin Migration] MaxExecFunction
Package: com.ichi2.utils
2021-11-09 09:28:40 -05:00
codingtosh
e085a4ea09 Rename MaxExecFunction.java to MaxExecFunction.kt
Package: com.ichi2.utils
2021-11-09 09:28:40 -05:00
codingtosh
341efb7288 [Kotlin Migration] VersionUtils
Package: com.ichi2.utils
2021-11-09 08:29:12 -05:00
codingtosh
84a4ea94e1 Rename VersionUtils.java to VersionUtils.kt
Package: com.ichi2.utils
2021-11-09 08:29:12 -05:00
codingtosh
1e7a0fa929 [Kotlin Migration] ThreadUtil
Package: com.ichi2.utils
2021-11-09 08:28:34 -05:00
codingtosh
6ef455cfab Rename ThreadUtil.java to ThreadUtil.kt
Package: com.ichi2.utils
2021-11-09 08:28:34 -05:00
codingtosh
88e9b5770a [Kotlin Migration] TextViewUtil
Package: com.ichi2.utils
2021-11-09 08:26:52 -05:00
codingtosh
fe6baf302a Rename TextViewUtil.java to TextViewUtil.kt
Package: com.ichi2.utils
2021-11-09 08:26:52 -05:00
codingtosh
4c92297655 [Kotlin Migration] Permissions
Package: com.ichi2.utils
2021-11-09 08:20:55 -05:00
codingtosh
e3f56b2154 Rename Permissions.java to Permissions.kt
Package: com.ichi2.utils
2021-11-09 08:20:55 -05:00
codingtosh
7df41662c4 [Kotlin Migration] NamedJSONComparator
Package: com.ichi2.utils
2021-11-09 08:19:30 -05:00
codingtosh
4e717976a9 Rename NamedJSONComparator.java to NamedJSONComparator.kt
Package: com.ichi2.utils
2021-11-09 08:19:30 -05:00
codingtosh
9f98d5caf7 [Kotlin Migration] MapUtil
Package: com.ichi2.utils
2021-11-09 08:15:26 -05:00
codingtosh
ea12ce04e3 Rename MapUtil.java to MapUtil.kt
Package: com.ichi2.utils
2021-11-09 08:15:26 -05:00
codingtosh
2aacafb1b0 [Kotlin Migration] KeyUtils
Package: com.ichi2.utils
2021-11-09 08:14:39 -05:00
codingtosh
5032325bf2 Rename KeyUtils.java to KeyUtils.kt
package: com.ichi2.utils
2021-11-09 08:14:39 -05:00
codingtosh
96051cdc9c [Kotlin Migration] JSONTokener
Package: com.ichi2.utils
2021-11-09 08:13:52 -05:00
codingtosh
1c0eb32944 Rename JSONTokener.java to JSONTokener.kt
Package: com.ichi2.utils
2021-11-09 08:13:52 -05:00
Piyush Goel
4ca81fdc3d Migrated SyncErrorDialog to kotlin 2021-11-09 08:11:22 -05:00
Piyush Goel
61b19ee4ff Renamed SyncErrorDialog.java to SyncErrorDialog.kt 2021-11-09 08:11:22 -05:00
codingtosh
cfb24e79f9 [Kotlin Migration] ExceptionUtil
Package: com.ichi2.utils
2021-11-09 12:52:10 +00:00
codingtosh
34df46d5ea Rename ExceptionUtil.java to ExceptionUtil.kt
Package: com.ichi2.utils
2021-11-09 12:52:10 +00:00
Piyush Goel
c85ee4caa1 Migrated RecursivePictureMenu to kotlin. 2021-11-08 14:38:47 -05:00
Piyush Goel
f9df7e363c Renamed RecursivePictureMenu.java to RecursivePictureMenu.kt 2021-11-08 14:38:47 -05:00
Piyush Goel
a7cceb5a67 Migrated MediaCheckDialog to kotlin. 2021-11-08 14:37:08 -05:00
Piyush Goel
218b37b5e5 Renamed MediaCheckDialog.java to MediaCheckDialog.kt 2021-11-08 14:37:08 -05:00
Piyush Goel
d72a257245 Migrated DeckPickerContextMenu to kotlin 2021-11-08 14:34:09 -05:00
Piyush Goel
640381c6e6 Renamed DeckPickerContextMenu.java to DeckPickerContextMenu.kt 2021-11-08 14:34:09 -05:00
Piyush Goel
0c0d6f75c3 Migrated CreateDeckDialog to kotlin. 2021-11-08 14:32:22 -05:00
Piyush Goel
7b74dcda2b Renamed CreateDeckDialog.java to CreateDeckDialog.kt 2021-11-08 14:32:22 -05:00
Piyush Goel
8427579d10 Migrated CardBrowserMySearchesDialog to kotlin. 2021-11-08 10:26:14 -05:00
Piyush Goel
acdc4c74b3 Renamed CardBrowserMySearchesDialog.java to CardBrowserMySearchesDialog.kt 2021-11-08 10:26:14 -05:00
Piyush Goel
fe14d1a9ff Migrated ExportDialog to kotlin. 2021-11-08 15:23:15 +00:00
Piyush Goel
f33d8ebddf Renamed ExportDialog.java to ExportDialog.kt. 2021-11-08 15:23:15 +00:00
codingtosh
85fbabb34f [Kotlin Migration] FileUtil
Package: com.ichi2.utils
2021-11-08 08:45:21 -05:00
codingtosh
7f11c63011 Rename FileUtil.java to FileUtil.kt
Package: com.ichi2.utils
2021-11-08 08:45:21 -05:00
codingtosh
4a4f00db51 [Kotlin Migration] DeckNameComparator
Package: com.ichi2.utils
2021-11-08 07:40:33 -05:00
codingtosh
663428ef3e Rename DeckNameComparator.java to DeckNameComparator.kt
Package: com.ichi2.utils
2021-11-08 07:40:33 -05:00
codingtosh
f96bdfbc1f [EditNote][DeckSelectionDialog] Highlight Selected item
Issue: #9755
2021-11-08 07:39:27 -05:00
codingtosh
17c80022ef [Kotlin Migration] JSON
Package: com.ichi2.utils
2021-11-08 07:37:50 -05:00
codingtosh
4a3f65c21e Rename JSON.java to JSON.kt
Package: com.ichi2.utils
2021-11-08 07:37:50 -05:00
codingtosh
7cd749f26a [Kotlin Migration] IntentUtil
Package: com.ichi2.utils
2021-11-08 07:37:07 -05:00
codingtosh
104738c52d Rename IntentUtil.java to IntentUtil.kt
Package: com.ichi2.utils
2021-11-08 07:37:07 -05:00
Piyush Goel
3be10c1492 Migrated SimpleMessageDialog to kotlin. 2021-11-08 12:31:20 +00:00
Piyush Goel
6dee0ffe13 Renamed SimpleMessageDialog.java to SimpleMessageDialog.kt 2021-11-08 12:31:20 +00:00
codingtosh
c55b5d9cb4 [Kotlin Migration] HtmlUtils
Package: com.ichi2.utils
2021-11-08 07:29:42 -05:00
codingtosh
527131bb96 Rename HtmlUtils.java to HtmlUtils.kt
Package: com.ichi2.utils
2021-11-08 07:29:42 -05:00
codingtosh
6b1b89b5ed [Kotlin Migration] HashUtil
Package: com.ichi2.utils
2021-11-08 07:29:10 -05:00
codingtosh
8150d55e16 Rename HashUtil.java to HashUtil.kt
Package: com.ichi2.utils
2021-11-08 07:29:10 -05:00
codingtosh
3c176046ec [Kotlin Migration] CollectionUtils
Package: com.ichi2.utils
2021-11-08 12:28:40 +00:00
codingtosh
1992752643 Rename CollectionUtils.java to CollectionUtils.kt
Package: com.ichi2.utils
2021-11-08 12:28:40 +00:00
codingtosh
d00c0fe1bc [Kotlin Migration] ContentResolverUtil
Package: com.ichi2.utils
2021-11-08 12:27:59 +00:00
codingtosh
4abfc5b3ef Rename ContentResolverUtil.java to ContentResovlerUtil.kt
Package: com.ichi2.utils
2021-11-08 12:27:59 +00:00
codingtosh
0e2b3d544d [Kotlin Migration] AndroidUiUtils
Package: com.ichi2.utils
2021-11-08 07:19:01 -05:00
codingtosh
c90f0f4b93 Rename AndroidUiUtils.java to AndroidUiUtils.kt
Package: com.ichi2.utils
2021-11-08 07:19:01 -05:00
codingtosh
8c5f205b49 [Kotlin Migration][FollowUp] Time
Resolve Warnings:
1. Kotlin's max() instead of Math.max()

Package: com.ichi2.libanki.utils
2021-11-07 20:55:47 -05:00
codingtosh
dd8c406437 [Kotlin Migration][FollowUp] Time
1. Remove Wildcard import.
2. Resolve import conflict -> Use import alias.

Package: com.ichi2.libanki.utils
2021-11-07 20:55:47 -05:00
Mike Hardy
b09e2a7631 Bumped version to 2.16alpha30 2021-11-07 22:28:43 +00:00
David Allison
0d0ba2cef3 refactor(IntegerDialog): JvmOverloads
Reduces the amount of Kotlin
2021-11-07 16:51:11 -05:00
David Allison
2819d4429e refactor(IntegerDialog): use extension method
`contentNullable` improves the method:

* Fluent, allowing us to return .show()
* Much less code
2021-11-07 16:51:11 -05:00
David Allison
1b214ef23f refactor(insert-field): lateinit variables
set via `withArguments`, which is always called
2021-11-07 16:51:11 -05:00
David Allison
2f4d8d5a70 refactor(import): make dialogMessage NonNull
This allows convertToDisplayName and filenameFromPath to accept
a non-null parameter
2021-11-07 16:51:11 -05:00
Piyush Goel
e00531ed75 Migrated ImportDialog to kotlin 2021-11-07 14:09:09 -05:00
Piyush Goel
f836fe45e5 Renamed ImportDialog.java to ImportDialog.kt 2021-11-07 14:09:09 -05:00
Piyush Goel
303e8688d2 Migrated WhiteBoardWidthDialog to kotlin 2021-11-07 14:08:18 -05:00
Piyush Goel
caf92d6950 Reanamed WhiteBoardWidthDialog.java to WhiteBoardWidthDialog.kt 2021-11-07 14:08:18 -05:00
Piyush Goel
be56511e88 Migrated InsertFieldDialog to kotlin. 2021-11-07 14:07:41 -05:00
Piyush Goel
beb8b24a5f Renamed InsertFieldDialog.java to InsertFieldDialog.kt 2021-11-07 14:07:41 -05:00
Piyush Goel
6a93b1f004 Migrated ExportCompleteDialog to kotlin. 2021-11-07 14:06:50 -05:00
Piyush Goel
5725bb10dc Renamed ExportCompleteDialog.java to ExportCompleteDialog.kt 2021-11-07 14:06:50 -05:00
Piyush Goel
f56243bde5 Migrated DeckPickerNoSpaceToDowngradeDialog to kotlin. 2021-11-07 14:06:00 -05:00
Piyush Goel
d3d4101fcc Renamed DeckPickerNoSpaceToDowngradeDialog.java to DeckPickerNoSpaceToDowngradeDialog.kt 2021-11-07 14:06:00 -05:00
Piyush Goel
2e1aa9b36b Migrated CardBrowserOrderDialog to kotlin. 2021-11-07 14:05:20 -05:00
Piyush Goel
2c8b2ad0a7 Renamed CardBrowserOrderDialog.java to CardBrowserOrderDialog.kt 2021-11-07 14:05:20 -05:00
Piyush Goel
5eb8dae26a Migrated IntegerDialog to kotlin. 2021-11-07 14:04:17 -05:00
Piyush Goel
b8f8a18537 Renamed IntegerDialog.java to IntegerDialog.kt. 2021-11-07 14:04:17 -05:00
David Allison
6c8450aa81 fix(miui): disable "force dark" mode
Force Dark is an Android 10 feature, which commonly appears on MIUI 12

This forces a dark mode, even if the app doesn't support it.
We have a night mode, so don't need it

This causes many problems, as it does not invert Note Editor icons
causing questions about missing functionality

`android:forceDarkAllowed` fixes this, but is API 29+

To fix this, define a theme overlay, and apply it to all activities

Note: Setting a theme doesn't replace the current theme, just
overriding the properties, so a second theme is an overlay

This removes the need to to duplicate the file for `values-29`

https://developer.android.com/guide/topics/ui/look-and-feel/darktheme#force-dark
https://stackoverflow.com/questions/63047806/

Fixes 8150
2021-11-07 14:00:29 -05:00
codingtosh
fe2d38966a [Kotlin Migration] SystemTime
Package: com.ichi2.libanki.utils
2021-11-07 13:55:39 -05:00
codingtosh
37374480a2 Rename SystemTime.java to SystemTime.kt
Package: com.ichi2.libanki.utils
2021-11-07 13:55:39 -05:00
codingtosh
11619a5340 [Kotlin Migration] StringUtils
Package: com.ichi2.libanki.utils
2021-11-07 13:55:04 -05:00
codingtosh
054865e258 Rename StringUtils.java to StringUtils.kt
Package: com.ichi2.libanki.utils
2021-11-07 13:55:04 -05:00
codingtosh
1316a17850 [Kotlin Migration] Assert
Package: com.ichi2.utils
2021-11-07 13:54:24 -05:00
codingtosh
d12d0a8f38 Rename Assert.java to Assert.kt
Package: com.ichi2.utils
2021-11-07 13:54:24 -05:00
codingtosh
bfabe73a7f [Kotlin Migration] AssertHelper
Package: com.ichi2.utils
2021-11-07 13:53:36 -05:00
codingtosh
8d1922ecbd Rename AssertHelper.java to AssertHelper.kt
Package: com.ichi2.utils
2021-11-07 13:53:36 -05:00
codingtosh
9342517e17 [Kotlin Migration] BundleUtils
Package: com.ichi2.utils
2021-11-07 13:52:23 -05:00
codingtosh
04de84c871 Rename BundleUtils.java to BundleUtils.kt
Package: com.ichi2.utils
2021-11-07 13:52:23 -05:00
codingtosh
8b1011e90d [Kotlin Migration] CheckCameraPermission
Package: com.ichi2.utils
2021-11-07 13:50:42 -05:00
codingtosh
79d9f2bf79 Rename CheckCameraPermission.java to CheckCameraPermission.kt
Package: com.ichi2.utils
2021-11-07 13:50:42 -05:00
codingtosh
a837ebddfb [Kotlin Migration] ClipboardUtil
Package: com.ichi2.utils
2021-11-07 13:49:49 -05:00
codingtosh
9606255aa1 Rename ClipboardUtil.java to ClipboardUtil.kt
Package: com.ichi2.utils
2021-11-07 13:49:49 -05:00
Piyush Goel
a98685af46 Migrated ExportListener to kotlin 2021-11-07 13:48:49 -05:00
Piyush Goel
4f74fe055c Renamed ExportListener.java to ExportListener.kt 2021-11-07 13:48:49 -05:00
Piyush Goel
e87c19e093 Migrated StyledProgressDialog to kotlin.
Co-authored-by: David Allison <62114487+david-allison-1@users.noreply.github.com>
2021-11-07 13:44:12 -05:00
Piyush Goel
7ac0c8f77d Renamed StyledProgressDialog.java to StyledProgressDialog.kt 2021-11-07 13:44:12 -05:00
codingtosh
b2140b50fb [Kotlin Migration] AdaptionUtil
Package: com.ichi2.utils
2021-11-07 13:40:37 -05:00
codingtosh
c0390073d4 Rename AdaptionUtil.java to AdaptionUtil.kt
Package: com.ichi2.utils
2021-11-07 13:40:37 -05:00
Piyush Goel
9e15650e98 Migrated DeckPickerNoSpaceLeftDialog to kotlin. 2021-11-06 15:19:03 -05:00
Piyush Goel
4f24841d9b Renamed DeckPickerNoSpaceLeftDialog.java to DeckPickerNoSpaceLeftDialog.kt 2021-11-06 15:19:03 -05:00
Piyush Goel
456d3fa3da Migrtated ConfirmationDialog to Kotlin. 2021-11-06 15:16:38 -05:00
Piyush Goel
dfedb17f23 Renamed ConfirmationDialog.java to ConfirmationDialog.kt 2021-11-06 15:16:38 -05:00
Piyush Goel
9a802f2d61 Migrated DeckPickerBackupNoSpaceLeftDialog to kotlin. 2021-11-05 20:05:07 +00:00
Piyush Goel
e66c579932 Renamed DeckPickerBackupNoSpaceLeftDialog.java to DeckPickerBackupNoSpaceLeftDialog.kt 2021-11-05 20:05:07 +00:00
Piyush Goel
864b373fbd Migrated DeckPickerAnalyticsOptInDialog to kotlin 2021-11-05 20:04:14 +00:00
Piyush Goel
2937fbda14 Renamed DeckPickerAnalyticsOptInDialog.java to DeckPickerAnalyticsOptInDialog.kt 2021-11-05 20:04:14 +00:00
Piyush Goel
e01f92a49e Migrated DeckPickerConfirmDeleteDeckDialog to kotlin. 2021-11-05 20:03:31 +00:00
Piyush Goel
3dfea70eb2 Renamed DeckPickerConfirmDeleteDeckDialog.java to DeckPickerConfirmDeleteDeckDialog.kt 2021-11-05 20:03:31 +00:00
Piyush Goel
d707e440e9 Migrated MaterialEditTextDialog to kotlin. 2021-11-05 20:03:06 +00:00
Piyush Goel
b5de1c8e59 Renamed MaterialEditTextDialog.java to MaterialEditTextDialog.kt 2021-11-05 20:03:06 +00:00
Piyush Goel
c5659789df Migrated ModelEditorContextMenu to kotlin. 2021-11-05 20:02:27 +00:00
Piyush Goel
6c9f88470d Renamed ModelEditorContextMenu.java to ModelEditorContextMenu.kt 2021-11-05 20:02:27 +00:00
Piyush Goel
e002fbb734 Migrated ModelBrowserContextMenu to kotlin 2021-11-05 08:44:37 -05:00
Piyush Goel
b74a3801d7 Renamed ModelBrowserContextMenu.java to ModelBrowserContextMenu.kt 2021-11-05 08:44:37 -05:00
Piyush Goel
39dad1f7d3 Migrated RecursivePictureMenuUtil to kotlin 2021-11-05 08:44:37 -05:00
Piyush Goel
f29e5aae0c Renamed RecursivePictureMenuUtil.java to RecursivePictureMenuUtil.kt 2021-11-05 08:44:37 -05:00
Piyush Goel
3929d8bbf2 Migrate RecursivePictureMenuTest to kotlin 2021-11-05 08:42:01 -05:00
Piyush Goel
3cba8f58d5 Renamed RecursivePictureMenuTest.java to RecursivePictureMenuTest.kt 2021-11-05 08:42:01 -05:00
AnkiDroid Translations
9d80f5baa6 Updated strings from Crowdin 2021-11-04 21:22:35 -05:00
Mike Hardy
34bd301594 build(deps): bump core/auto-service/activity/browser deps
- FieldEditText took a new deprecation, tracked in #9775
- SharedDecksActivity generated a new build warning that it was not overriding onCreateOptionsMenu,
  it was just a nullability difference, the superclass method is non-null Menu argument
2021-11-04 20:45:40 -05:00
dependabot[bot]
4246143fa6 build(deps): bump annotation from 1.2.0 to 1.3.0
Bumps annotation from 1.2.0 to 1.3.0.

---
updated-dependencies:
- dependency-name: androidx.annotation:annotation
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-11-04 20:45:40 -05:00
dependabot[bot]
5950c008e6 build(deps): bump auto-service from 1.0 to 1.0.1
Bumps [auto-service](https://github.com/google/auto) from 1.0 to 1.0.1.
- [Release notes](https://github.com/google/auto/releases)
- [Commits](https://github.com/google/auto/compare/auto-value-1.0...auto-common-1.0.1)

---
updated-dependencies:
- dependency-name: com.google.auto.service:auto-service
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-11-04 20:45:40 -05:00
Mike Hardy
0e43472891 fix(android, api31): implement compileSdkVersion 31 compatibility
- added new CompatV31 object to compat infrastructure
- handled MediaRecorder() ctor deprecation by threading Context through, adding new Compat method
- handled Context.VIBRATOR_SERVICE deprecation with recommended new APIs in CompatV31 override
2021-11-04 17:03:01 -05:00
Piyush Goel
d3b54dd923 Migrate DiscardChangesDialog to kotlin 2021-11-04 17:01:00 -05:00
Piyush Goel
770a4d283a Renamed DiscardChangesDialog.java to DiscardChangesDialog.kt 2021-11-04 17:01:00 -05:00
codingtosh
370ff170d5 Migrate Time to Kotlin
Package: com.ichi2.libanki.utils
2021-11-04 16:59:47 -05:00
codingtosh
13fc832adc Rename Time.java to Time.kt 2021-11-04 16:59:47 -05:00
Piyush Goel
0634c00624 Migration of LocaleSelectionDialog to Kotlin 2021-11-04 16:55:19 -05:00
Piyush Goel
b92ba7dde0 Renamed LocaleSelectionDialog.java to LocaleSelectionDialog.kt 2021-11-04 16:55:19 -05:00
codingtosh
d86d7ed0df [EditNote][DeckSpinner] Fix Layout Height
This changes the spinner layout_height from 48dp to wrap_content
which enables the Spinner View to completely display selected deck
names occupying more than 2 lines.

Issue: #9750
2021-11-03 03:53:33 +01:00
Arthur Milchior
cd4b9f1377 NF: Replace bundle argument String by constant 2021-11-02 09:43:02 -05:00
Arthur Milchior
da5ca58435 NF: removing selectDropDownItem
This method became thanks to previous commits. The change in test also ensure
that the actual meaningful action is done instead of using the position
2021-11-02 09:43:02 -05:00
Arthur Milchior
149352201a NF: remove mDeckId from DeckSpinnerSelection
selectDropDownItem was buggy. It only worked as expected if the list of deck
starts with "All decks". Otherwise (i.e. in the note editor) mDecksId has an
off-by-one error.

This is not actually important because mDeckId was used in a single place, in
getDeckId from Statistics. All other users of the deck spinner (card browser and
note editor) save the deck id themselves.

This update statistics so that it also keep track of deck id itself. This ensure
that there is no need to correct the bug as the variable is not used anymore.

The member is called mStatsDeckId so that it can't be mixed with mDeckId.
2021-11-02 09:43:02 -05:00
Arthur Milchior
4b10953031 NF: updateDeckPosition takes deck id as argument
This will allow in next commit to remove mCurrentDid
It works because updateDeckPosition is always aclled after setDeckId is called
2021-11-02 09:43:02 -05:00
Arthur Milchior
d1faef8cc4 NF: replace getSpinner by hasSpinner
It ensures the spinner does not escape the classe's scope
2021-11-02 09:43:02 -05:00
Arthur Milchior
447d1ea5e0 NF: simplify CardBrowser's selectAllDecks
This keep the logic by choosing to selectAllDecks instead of indicating a
specific position.

The goal, in next commit, being to remove this method.
2021-11-02 09:43:02 -05:00
Arthur Milchior
17066c3642 NF: selectAllDecks send a report if it is used without all decks
While it probably is impossible right now, this will ensure we catch the error
in alpha/beta testing if a change use it by accident later.

Note that selectDeckId return value is never used. So returning false in this
case works as well
2021-11-02 09:43:02 -05:00
Arthur Milchior
1339b72f42 NF: rename searchInList to selectDeck
This describe the result instead of the implementation
2021-11-02 09:43:02 -05:00
Arthur Milchior
ae0affa5e6 NF: Clarify initializeNoteEditorDeckSpinner 2021-11-02 09:43:02 -05:00
Arthur Milchior
8f1a0e7b55 NF: simplify getDropDownDecks
getDropDownDecks was overloaded, and both methods did different things. One
compute the deck, the other one return the list already computed. Furthermore,
the one computing took the collection as argument, which was useless given that
it is a member of the object.

So I renamed the computing one from get to compute, and I removed its parameter
2021-11-02 09:43:02 -05:00
Arthur Milchior
0b74559ff4 NF: alwaysShowDefault is final. Move it to constructor 2021-11-02 09:43:02 -05:00
Arthur Milchior
2b0b7c47ac NF: move mShowAllDecks to final, add it in constructor 2021-11-02 09:43:02 -05:00
Arthur Milchior
efe31ca014 NF: remove an unused constructor 2021-11-02 09:43:02 -05:00
Arthur Milchior
9c285185bd NF: Comments in DeckSpinnerSelection 2021-11-02 09:43:02 -05:00
David Allison
9dfee13c82 feat(v16): Load Audio from backend
This uses `render_content().[question/answer]_av_tags` to obtain
 backend data, instead of manually parsing `[sound:]` tags

Note: Only for sounds, the play buttons from audio and
TTS are unhandled. Content is still mostly from frontend

Fixes tests in AbstractFlashcardViewerSoundRenderTest in v16
2021-11-02 09:27:12 -05:00
codingtosh
4e26c01a6c [EditNote][DeckSpinner] Display long name
This ensures that the selected item with a long name from the
deck spinner is displayed completely in multiple lines and not
displayed partially in a single line.

Issue: #9750
2021-11-02 03:38:17 +01:00
Arthur Milchior
81b77abc00 Ensure a single note type is highlighted
Fixes 9754

The error, I believe, was that the textview was recycled, which mean that we
need to reset the color.

Tested on my device. The problem disappeared. Tested in night and day mode, got
the correct color each time
2021-11-01 18:24:39 -05:00
David Allison
51d948b2eb tests: AbstractFlashcardViewerSoundRenderTest
To guard against regressions in the V16 conversion
2021-11-01 10:01:39 -05:00
David Allison
627b5390a1 fix: addNonClozeModel 2021-11-01 10:01:39 -05:00
David Allison
974c915066 refactor: extract methods to CardHtml
getAnswerFormat
removeFrontSideAudio

These will be used internally in an upcoming functionality update

No need for them to be in the CardViewer
2021-11-01 10:01:39 -05:00
David Allison
a31eae457e nf: make methods static
getAnswerFormat
removeFrontSideAudio

These will be extracted
2021-11-01 10:01:39 -05:00
David Allison
9ef17c08e8 refactor: inline "addSounds"
This moves the sound parsing logic out of `Sound`.

The plan is to defer this to the Rust backend if available.
We can't do this if we need to provide the sounds
2021-11-01 10:01:39 -05:00
David Allison
508abc29b6 feat(sounds): addSounds - accept SoundOrVideoTag
The rust backend is responsible for the Sound/Video Tags

This commit splits out the generation and adding of the tags.
After this, we can defer the generation further down the call chain,
meaning it can be pre-processed in Rust
2021-11-01 10:01:39 -05:00
Mike Hardy
c6ef93c4fb Bumped version to 2.16alpha29 2021-10-31 19:58:35 +00:00
David Allison
1b3c687bfc feat(v16): implement findCards in backend
This is a simple change, but FindCards also throws an exception

Documented InvalidSearchException and added it to SearchCardsResult

Note: i18n now depends on Anki-Android-Backend and is not implemented

Fixes 9573
Related: 8307 - fixed after a backend upgrade
Fixes 8116
Fixes 6427
Fixes 5543
Fixes 5308
Fixes 4821 (brings us to ecosystem compatibility, new issue needs to be implemented on Anki Desktop)
2021-10-31 13:32:07 -05:00
David Allison
019c32c328 refactor: extract SearchCardsResult
We want to extend this class to include an error
2021-10-31 13:32:07 -05:00
David Allison
442d57cead fix(search): V16 compat with bracketed tag search
This allows a v16 searchCards to return without erroring

correct search: `"tag:sketchy::(1)"`

Related: 7070
2021-10-31 13:32:07 -05:00
David Allison
b0cb2174c4 refactor: Introduce SortOrder class
This better documents the Collection.findCards method and makes
it simpler to match the backend definition
2021-10-31 13:32:07 -05:00
David Allison
5ca550c925 feat: add EnumMirror annotation
Ensures that Backend enums match our enums

tests: We have a problem with getting all classes with an annotation
 so for now, we hardcode the list inside the test
2021-10-31 13:32:07 -05:00
Mani
ae2b26febb removed current card from constructor and access directly from activity 2021-10-31 13:31:08 -05:00
Anand
f97943bfe9
build(deps): move acra version to root build.gradle (#9745)
* Update build.gradle
2021-10-31 13:27:32 -05:00
codingtosh
ed7676948c Migrate ArrayUtil to Kotlin 2021-10-31 13:24:07 -05:00
codingtosh
89f50c09fc Rename ArrayUtil.java to ArrayUtil.kt 2021-10-31 13:24:07 -05:00
David Allison
1ee5f65b87 docs: Kotlin Conversion
Better to write this than to explain it.

https://github.com/ankidroid/Anki-Android/pull/9480
2021-10-31 13:23:23 -05:00
dependabot[bot]
0bb524fea1 build(deps): bump protobuf-java from 3.19.0 to 3.19.1
Bumps [protobuf-java](https://github.com/protocolbuffers/protobuf) from 3.19.0 to 3.19.1.
- [Release notes](https://github.com/protocolbuffers/protobuf/releases)
- [Changelog](https://github.com/protocolbuffers/protobuf/blob/master/generate_changelog.py)
- [Commits](https://github.com/protocolbuffers/protobuf/compare/v3.19.0...v3.19.1)

---
updated-dependencies:
- dependency-name: com.google.protobuf:protobuf-java
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-10-31 13:21:52 -05:00
codingtosh
bbd2f009a7 [Preferences:Focus type in answer]Enable dy default
Issue: #3482
2021-10-31 11:18:23 -05:00
David Allison
571c2dcf31 feat(v16): Implement col.render_output via rust
Minor fix for CardTemplatePreviewer as we can no longer render a
card which is not saved via render_output
2021-10-31 11:16:39 -05:00
David Allison
9bfceb3ac8 feat(eco-compat): render_output returns class
Matches Anki Desktop

This class also supports CSS and AV Tags

We add CSS support, but AV tags are not yet supported (Rust Only)

So we convert the following to nullable:

TemplateRenderOutput.question_av_tags
TemplateRenderOutput.answer_av_tags
2021-10-31 11:16:39 -05:00
David Allison
584161eb8d nf: extract render_output to collection
This is not part of libAnki, overridable for the rust implementation
2021-10-31 11:16:39 -05:00
David Allison
28736a6345 nf(eco-compat): rename _getQA to render_output
This is what Anki Desktop has named the method in 2.1.34
2021-10-31 11:16:39 -05:00
David Allison
86f5dd284b Convert template.py from Anki Desktop
https://github.com/ankitects/anki/blob/2.1.34/pylib/anki/template.py

untested

We exclude hook-based functionality for now
2021-10-30 16:20:59 +01:00
David Allison
253706a403 Convert sound.py from Anki Desktop
https://github.com/ankitects/anki/blob/2.1.34/pylib/anki/sound.py
2021-10-30 16:20:59 +01:00