dorrin-sot
8db4f8a009
Fixed Reviewer not updating after changing card in Browser
2022-05-26 22:22:15 +02:00
lukstbit
11d6832ec6
Cleanup for file RemoteServer.kt
2022-05-26 15:51:37 +02:00
lukstbit
44a3850d29
Refactor to use Collection parameter in onCollectionLoaded callback
2022-05-26 15:45:36 +02:00
Prince kushwaha
c4f0b56956
Migrate PeripheralKeymapTest.java to Kotlin
2022-05-24 09:56:27 -05:00
Prince kushwaha
510d87a128
Rename PeripheralKeymapTest.java to PeripheralKeymapTest.kt
2022-05-24 09:56:27 -05:00
Prince kushwaha
85648e8434
Migrate ActionBarOverflowTest.java to Kotlin
2022-05-24 09:44:51 -05:00
Prince kushwaha
cc82aeca98
Rename ActionBarOverflowTest.java to ActionBarOverflow.kt
2022-05-24 09:44:51 -05:00
Brayan Oliveira
54bb419f38
Add support to <audio> and <object>
...
This follows upstream, so the media contained on these tags won't be deleted
reference: b403f20cae/pylib/anki/media.py (L34-L45)
2022-05-24 09:29:00 -05:00
lukstbit
7934f58593
Refactor code around DatabaseLock
2022-05-22 03:09:18 +02:00
lukstbit
70bacb0e52
Migrate Tags.java to kotlin
2022-05-18 15:00:30 -05:00
lukstbit
8a7d7a451d
Rename Tags.java to .kt
2022-05-18 15:00:30 -05:00
lukstbit
5b44d77ac3
Fix ModelFieldEditor leaking ModelEditorContextMenu
...
To solve the leak and decouple the two classes, this PR also:
- refactors the ModelEditorContextMenu class to remove it's reference to the activity
- fixes a @KotlinCleanup for the method where the leak occurs
- removes the @RequiresApi for AddLanguageHint, ModelEditorContextMenu will trigger this action only when possible
2022-05-18 13:08:04 -05:00
Prince kushwaha
0c8a93934e
Migrate CheckMediaTest.java to Kotlin
2022-05-18 12:03:52 -05:00
Prince kushwaha
7b7b642da6
Rename CheckMediaTest.java to CheckMediaTest.kt
2022-05-18 12:03:52 -05:00
Prince kushwaha
6138d8ebbb
Migrate DiffEngineTest.java to Kotlin
2022-05-18 11:48:25 -05:00
Prince kushwaha
f4e289ec21
Rename DiffEngineTest.java to DiffEngineTest.kt
2022-05-18 11:48:25 -05:00
lukstbit
387c761b3c
Migrate TextNoteExporter.java to kotlin
2022-05-18 10:17:30 -05:00
lukstbit
66301a770e
Rename TextNoteExporter.java to .kt
2022-05-18 10:17:30 -05:00
MrPenguins
7900ef700a
Fixed a bug about NavigateUp Button on DeckOverview screen ( #11005 )
2022-05-18 09:23:37 -05:00
Mike Hardy
f604eb8a56
lint: suppress naming check here for AGP7.2 compat
...
this was tripping the detector, and cleaning it right now is orthogonal
to goal of getting AGP in
2022-05-17 13:15:55 -05:00
dependabot[bot]
df55e82d93
build(deps): bump mockk from 1.12.3 to 1.12.4
...
Bumps [mockk](https://github.com/mockk/mockk ) from 1.12.3 to 1.12.4.
- [Release notes](https://github.com/mockk/mockk/releases )
- [Commits](https://github.com/mockk/mockk/compare/1.12.3...1.12.4 )
---
updated-dependencies:
- dependency-name: io.mockk:mockk
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2022-05-17 13:15:55 -05:00
lukstbit
94d8d85e12
Migrate FunctionalInterfaces.java to kotlin
2022-05-15 10:29:52 -05:00
lukstbit
f53c54b1e3
Rename FunctionalInterfaces.java to .kt
2022-05-15 10:29:52 -05:00
David Allison
8741aae721
refactor: Convert Collection to Kotlin
...
com.ichi2.libanki.Collection
clearUndo was inlined
crt is now always a long
loadColumn - changed 'break' to 'return'
introduced dbClosed to remove the need for a nullable DB
2022-05-14 17:16:58 -05:00
David Allison
355b5a7c37
refactor: Rename Collection.java to .kt
...
com.ichi2.libanki.Collection
2022-05-14 17:16:58 -05:00
lukstbit
b312ce26bb
Migrate IField.java to kotlin
2022-05-14 16:48:15 -05:00
lukstbit
d580eebd47
Rename IField.java to .kt
2022-05-14 16:48:15 -05:00
camo0112
fdaef5cdf5
added test for CountModels
2022-05-14 16:41:19 -05:00
camo0112
b930323054
added test for CountModels
2022-05-14 16:41:19 -05:00
oyeraghib
231df20213
[Kotlin Cleanup] Various Files
2022-05-14 15:46:29 +01:00
oyeraghib
97b150728e
[Kotlin Cleanup] JSONArrayTest
2022-05-14 14:46:45 +01:00
oyeraghib
05b96990ce
[Kotlin Cleanup] CollectionUtils
2022-05-13 10:30:09 -05:00
oyeraghib
381b1bd2af
[Kotlin Cleanup] MockCursor
2022-05-13 10:25:09 -05:00
lukstbit
3fa836ba99
Refactor IField to prepare for its migration to java
...
Actions:
- remove unsused methods
- change signatures of methods to make the transition to properties easier
- rename an extra reference of a property from one of the subclasses of IField which would clash with some class methods
during migration
2022-05-13 10:24:26 -05:00
oyeraghib
21d8a142ee
[Kotlin Cleanup] ReminderServiceTest
2022-05-13 10:18:40 -05:00
dorrin-sot
9101795b3c
Fix AutoFocus EditText Preferences Back/Return Button Bug
2022-05-13 10:17:55 -05:00
lukstbit
6306a0aec6
Fix ModelBrowser leaking its ModelBrowserContextMenu reference
...
To solve the leak and decouple the two classes, this PR also:
- refactors the ModelBrowserContextMenu class to remove it's reference to the activity
- fixes a @KotlinCleanup for the method where the leak occurs
2022-05-13 10:16:10 -05:00
David Allison
2704fcb866
feat(scoped-storage): complete migrateEssentialFiles ( #11049 )
...
* feat(scoped-storage): implement migrateEssentialFiles
Handles selection of the correct directory, and handling deletion
if an issue occurred with the copy
Co-authored-by: Arthur Milchior <arthur@milchior.fr>
2022-05-13 10:03:37 -05:00
David Allison
fa15aeb759
fix: invalid sourceSets for Android Chipmunk
...
Due to https://issuetracker.google.com/issues/37001185 we were defining
`manifest.srcFile` for `debug` instead of for `test`. This is
because manifest merging previously occurred only with build variants
Was required for robolectric. Apparently fixed in AGP 0.13.0:
https://issuetracker.google.com/issues/37001185
It seems we can manifest merge based on 'test' and 'androidTest',
so remove the `debug` sourceSet.
This caused a bug on Android Chipmunk, as we included 'test' in the
'main' source set due to a change in how sourceSets were processed
Fixes 11291
Main comments: https://issuetracker.google.com/issues/232007221
https://issuetracker.google.com/issues/220326930
Originally added in ee463c2a3e
2022-05-12 11:36:03 -05:00
Mike Hardy
f731c47c5b
fix(test): shorten time and use greaterThanOrEqualTo for sleep test
2022-05-12 09:06:28 -05:00
lukstbit
6f40e0211c
Ignore image and audio paths check for text based fields
2022-05-12 08:21:50 -05:00
David Allison
1fa46e39b7
refactor: Kotlin Cleanup
2022-05-12 08:12:07 -05:00
David Allison
7813b56cab
refactor: IDE Lint
2022-05-12 08:12:07 -05:00
David Allison
65eb32de13
refactor: Kotlin Cleanup: nullability
2022-05-12 08:12:07 -05:00
David Allison
03e41e7fe6
refactor: Kotlin Cleanup: nullability
2022-05-12 08:12:07 -05:00
David Allison
f80c4e8a3e
refactor: Kotlin Cleanup: nullability
2022-05-12 08:12:07 -05:00
lukstbit
ca058f9226
Remove useless abstraction for IControllerFactory
2022-05-12 07:56:00 -05:00
David Allison
2902cff08d
docs: Rationale for @NeedsTest
...
Explain the impact now: new contributors think about tests,
and encourage tests to be written without being overbearing
And future plans: moving to a codebase with better coverage and
better formalizing the requirements for writing a test for GSoC
2022-05-12 07:46:05 -05:00
Jatin
df38bc3f49
[KotlinCleanup] AsyncDialogFragment.kt ( #11287 )
2022-05-12 10:02:58 +01:00
oyeraghib
888b518ac2
[Kotlin Cleanup] ListUtil
2022-05-11 09:18:05 -05:00
