mirror of
https://github.com/ankidroid/Anki-Android.git
synced 2024-09-20 03:52:15 +02:00
4154a37398
This is required for it to work on Java 11, and the old version in use without this change is obsolete (because it does not work on java11) Note that GitHub macos-latest - which is used by the workflow that runs this script as well as normal development environments - has this installed, verified in: https://github.com/actions/virtual-environments/blob/main/images/macos/macos-10.15-Readme.md#android (command line tools 4.x is sufficient, it is current "latest" and is installed)
59 lines
2.1 KiB
Bash
Executable File
59 lines
2.1 KiB
Bash
Executable File
#!/bin/bash
|
||
# Spot malformed string replacement patterns in Android localization files.
|
||
# Hopefully it will prevent this kind of bugs: https://code.google.com/p/ankidroid/issues/detail?id=359
|
||
|
||
# shellcheck disable=SC2016
|
||
EXIT_STATUS=0
|
||
|
||
pushd AnkiDroid/src/main > /dev/null || exit 1
|
||
if grep -RHn "%1$ s" res/values*; then
|
||
echo "Found '%1$ s'-related error"
|
||
EXIT_STATUS=$((EXIT_STATUS + 1));
|
||
fi
|
||
if grep -RHn "%1$ d" res/values*; then
|
||
echo "Found '%1$ s'-related error"
|
||
EXIT_STATUS=$((EXIT_STATUS + 1));
|
||
fi
|
||
if grep -RHn "%1" res/values* | grep -v "%1\\$"; then
|
||
echo "Found '%1'-related error"
|
||
EXIT_STATUS=$((EXIT_STATUS + 1));
|
||
fi
|
||
|
||
# This is currently not working and I'm not sure why? It worked a couple days ago as of 20200516
|
||
echo "The next test will likely only run correctly on macOS. On Ubuntu it does not work well."
|
||
if grep -RHn '%' res/values* |
|
||
sed -e 's/%/\n%/g' | # Split lines that contain several expressions
|
||
grep '%' | # Filter out lines that do not contain expressions
|
||
grep -v ' n% ' | # Lone % character, not a variable
|
||
grep -v '(n%)' | # Lone % character, not a variable
|
||
grep -v 'n%<' | # Same, at the end of the string
|
||
grep -v '>n% ' | # Same, at the beginning of the string
|
||
grep -v '%で' | # Same, no spaces in Japanese
|
||
grep -v '%s' | # Single string variable
|
||
grep -v '%d' | # Single decimal variable
|
||
grep -v '%[0-9][0-9]\?$s' | # Multiple string variable
|
||
grep -v '%[0-9][0-9]\?$d' | # Multiple decimal variable
|
||
grep -v '%1$.1f' | # ?
|
||
grep -v '%.1f' |
|
||
grep -v '%\\n' |
|
||
grep -v 'stats_overview_card_types_'
|
||
then
|
||
echo "Found grep errors but if you are not on macOS they are likely false positive. Ignoring"
|
||
#EXIT_STATUS=$((EXIT_STATUS + 1))
|
||
fi
|
||
|
||
if grep -RHn '％' res/values*; then
|
||
echo "Found errors in simple '%' grep"
|
||
EXIT_STATUS=$((EXIT_STATUS + 1));
|
||
fi
|
||
|
||
if grep -RHn "CDATA " res/values*; then
|
||
echo "Found CDATA-related errors"
|
||
EXIT_STATUS=$((EXIT_STATUS + 1));
|
||
fi
|
||
|
||
${ANDROID_HOME}/cmdline-tools/latest/bin/lint --check StringFormatInvalid ./res
|
||
popd > /dev/null || exit 1
|
||
echo "Exiting with status $EXIT_STATUS"
|
||
exit $EXIT_STATUS
|