mirror of
https://github.com/PHPMailer/PHPMailer.git
synced 2024-09-20 01:52:15 +02:00
cbecbc956b
The test code remaining in the `testEmbeddedImage()` constitutes one test.
This commit:
* Renames the test method and improves the description in the docblock.
* Removes the redundant call to `PHPMailer::clearAttachments()`.
This call was previously needed as multiple situations were being tested in one test method.
Now each test case has its own test method, the call to `PHPMailer::clearAttachments()` is no longer needed as each test method will receive a fresh, clean instance of the `PHPMailer` class.
* Replace a redundant condition and "forced" failure assertion with an assertion actually testing the result of the method call.
* Removes the redundant `return` - if an assertion fails, the rest of the code within the test method will not be executed anyway.
|
||
|---|---|---|
| .. | ||
| Language | ||
| OAuth | ||
| PHPMailer | ||
| POP3 | ||
| Security | ||
| DebugLogTestListener.php | ||
| fakefunctions.php | ||
| fakepopserver.sh | ||
| fakesendmail.sh | ||
| PreSendTestCase.php | ||
| runfakepopserver.sh | ||
| SendTestCase.php | ||
| testbootstrap-dist.php | ||
| TestCase.php | ||
| validators.php | ||