mirror of
https://github.com/signalapp/Signal-Server.git
synced 2024-09-19 19:42:18 +02:00
Move WebSocketClient SecureRandom to a static field
This commit is contained in:
parent
fd9eb462cc
commit
3d32b68bb2
@ -5,7 +5,6 @@
|
|||||||
package org.whispersystems.websocket;
|
package org.whispersystems.websocket;
|
||||||
|
|
||||||
import com.google.common.net.HttpHeaders;
|
import com.google.common.net.HttpHeaders;
|
||||||
import java.io.IOException;
|
|
||||||
import java.nio.ByteBuffer;
|
import java.nio.ByteBuffer;
|
||||||
import java.security.SecureRandom;
|
import java.security.SecureRandom;
|
||||||
import java.util.List;
|
import java.util.List;
|
||||||
@ -14,8 +13,8 @@ import java.util.Optional;
|
|||||||
import java.util.concurrent.CompletableFuture;
|
import java.util.concurrent.CompletableFuture;
|
||||||
import org.eclipse.jetty.websocket.api.RemoteEndpoint;
|
import org.eclipse.jetty.websocket.api.RemoteEndpoint;
|
||||||
import org.eclipse.jetty.websocket.api.Session;
|
import org.eclipse.jetty.websocket.api.Session;
|
||||||
import org.eclipse.jetty.websocket.api.exceptions.WebSocketException;
|
|
||||||
import org.eclipse.jetty.websocket.api.WriteCallback;
|
import org.eclipse.jetty.websocket.api.WriteCallback;
|
||||||
|
import org.eclipse.jetty.websocket.api.exceptions.WebSocketException;
|
||||||
import org.slf4j.Logger;
|
import org.slf4j.Logger;
|
||||||
import org.slf4j.LoggerFactory;
|
import org.slf4j.LoggerFactory;
|
||||||
import org.whispersystems.websocket.messages.WebSocketMessage;
|
import org.whispersystems.websocket.messages.WebSocketMessage;
|
||||||
@ -26,15 +25,15 @@ import org.whispersystems.websocket.messages.WebSocketResponseMessage;
|
|||||||
public class WebSocketClient {
|
public class WebSocketClient {
|
||||||
|
|
||||||
private static final Logger logger = LoggerFactory.getLogger(WebSocketClient.class);
|
private static final Logger logger = LoggerFactory.getLogger(WebSocketClient.class);
|
||||||
|
private static final SecureRandom SECURE_RANDOM = new SecureRandom();
|
||||||
|
|
||||||
private final Session session;
|
private final Session session;
|
||||||
private final RemoteEndpoint remoteEndpoint;
|
private final RemoteEndpoint remoteEndpoint;
|
||||||
private final WebSocketMessageFactory messageFactory;
|
private final WebSocketMessageFactory messageFactory;
|
||||||
private final Map<Long, CompletableFuture<WebSocketResponseMessage>> pendingRequestMapper;
|
private final Map<Long, CompletableFuture<WebSocketResponseMessage>> pendingRequestMapper;
|
||||||
private final long created;
|
private final long created;
|
||||||
|
|
||||||
public WebSocketClient(Session session, RemoteEndpoint remoteEndpoint,
|
public WebSocketClient(Session session, RemoteEndpoint remoteEndpoint, WebSocketMessageFactory messageFactory,
|
||||||
WebSocketMessageFactory messageFactory,
|
|
||||||
Map<Long, CompletableFuture<WebSocketResponseMessage>> pendingRequestMapper) {
|
Map<Long, CompletableFuture<WebSocketResponseMessage>> pendingRequestMapper) {
|
||||||
this.session = session;
|
this.session = session;
|
||||||
this.remoteEndpoint = remoteEndpoint;
|
this.remoteEndpoint = remoteEndpoint;
|
||||||
@ -105,7 +104,7 @@ public class WebSocketClient {
|
|||||||
}
|
}
|
||||||
|
|
||||||
private long generateRequestId() {
|
private long generateRequestId() {
|
||||||
return Math.abs(new SecureRandom().nextLong());
|
return Math.abs(SECURE_RANDOM.nextLong());
|
||||||
}
|
}
|
||||||
|
|
||||||
}
|
}
|
||||||
|
Loading…
Reference in New Issue
Block a user