0
0
mirror of https://github.com/TrianguloY/UrlChecker.git synced 2024-09-19 20:02:16 +02:00

fix urlData not persisting on automatic updates

fixes #205
This commit is contained in:
TrianguloY 2023-03-16 20:57:28 +01:00
parent de76b2a271
commit 5a942f0eaa
2 changed files with 9 additions and 9 deletions

View File

@ -66,13 +66,13 @@ public class MainDialog extends Activity {
/**
* Something wants to set a new url.
*/
public void onNewUrl(UrlData urlData) {
public void onNewUrl(UrlData newUrlData) {
// mark as next if nothing else yet
if (updating != 0) {
AndroidUtils.assertError("Don't call onNewUrl while updating, use the onModifyUrl return value");
return;
}
this.urlData = urlData;
urlData = newUrlData;
// fire updates loop
main_loop:
@ -99,11 +99,11 @@ public class MainDialog extends Activity {
// skip own if required
if (!urlData.triggerOwn && module == urlData.trigger) continue;
try {
var newUrlData = module.onModifyUrl(urlData);
if (newUrlData != null) {
var modifiedUrlData = module.onModifyUrl(urlData);
if (modifiedUrlData != null) {
// modified, restart
newUrlData.mergeData(urlData);
urlData = newUrlData;
modifiedUrlData.mergeData(urlData);
urlData = modifiedUrlData;
continue main_loop;
}
} catch (Exception e) {

View File

@ -164,7 +164,7 @@ class OpenDialog extends AModuleDialog {
@Override
public void onDisplayUrl(UrlData urlData) {
updateSpinner();
updateSpinner(urlData.url);
}
// ------------------- Spinner -------------------
@ -172,8 +172,8 @@ class OpenDialog extends AModuleDialog {
/**
* Populates the spinner with the apps that can open it, in preference order
*/
private void updateSpinner() {
packages = PackageUtils.getOtherPackages(UrlUtils.getViewIntent(getUrl(), null), getActivity());
private void updateSpinner(String url) {
packages = PackageUtils.getOtherPackages(UrlUtils.getViewIntent(url, null), getActivity());
// remove referrer
if (noReferrerPref.get()) {