From d51653af0d22935561f9f838cc8d6077b02b464a Mon Sep 17 00:00:00 2001 From: TrianguloY Date: Mon, 15 Jul 2024 13:03:24 +0200 Subject: [PATCH] avoid IndexOutOfBounds with query `=` fixes #365 --- .../urlchecker/modules/list/RemoveQueriesModule.java | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/app/src/main/java/com/trianguloy/urlchecker/modules/list/RemoveQueriesModule.java b/app/src/main/java/com/trianguloy/urlchecker/modules/list/RemoveQueriesModule.java index 5070c91..234ebb5 100644 --- a/app/src/main/java/com/trianguloy/urlchecker/modules/list/RemoveQueriesModule.java +++ b/app/src/main/java/com/trianguloy/urlchecker/modules/list/RemoveQueriesModule.java @@ -18,7 +18,6 @@ import com.trianguloy.urlchecker.url.UrlData; import com.trianguloy.urlchecker.utilities.methods.AndroidUtils; import com.trianguloy.urlchecker.utilities.methods.Inflater; -import java.net.URLDecoder; import java.util.ArrayList; import java.util.Arrays; import java.util.List; @@ -190,16 +189,16 @@ class RemoveQueriesDialog extends AModuleDialog { * Returns the name of a query (by index) */ public String getQueryName(int index) { - return queries.get(index).split("=")[0]; + return splitFix(queries.get(index),"=").get(0); } /** * Returns the decoded value of a query (by index) */ public String getQueryValue(int index) { - String[] split = queries.get(index).split("="); - if (split.length == 1) return ""; - return decode(split[1]); + var split = splitFix(queries.get(index),"="); + if (split.size() <= 1) return ""; + return decode(split.get(1)); } /**