mirror/libsignal
0
0
Fork 0
mirror of https://github.com/signalapp/libsignal.git synced 2024-09-20 03:52:17 +02:00
Code
47f221e9ab
libsignal/node/docker-prebuildify.sh

38 lines
1.2 KiB
Bash
Raw Normal View History

GitHub: Build Ubuntu Node releases using Docker, for Ubuntu 16 compat The only supported way to target an older glibc is to build against that glibc; consequently, we need to build on an Ubuntu 16 system (or similar) to target Ubuntu 16. This requires downloading second-party versions of Clang and CMake, which are too old in the default Ubuntu repository, as well as building our own Python. Do all this in a new Dockerfile based on Ubuntu 16.04. This isn't as rigorous as the Java "reproducible build" Dockerfile, since we're not pinning the base image or the repositories we're fetching from, but it's still an image with the environment and tools we need.
2022-08-02 00:11:51 +02:00
#!/bin/bash
# shellcheck disable=SC1004
#
# Copyright 2022 Signal Messenger, LLC.
# SPDX-License-Identifier: AGPL-3.0-only
#
set -euo pipefail
SCRIPT_DIR=$(dirname "$0")
cd "${SCRIPT_DIR}"/..
DOCKER_IMAGE=libsignal-node-builder
Docker: Use -it and --init to handle SIGTERM (^C) properly -i (interactive) and -t (allocate a tty) allow the shell running inside Docker to handle Ctrl-C (^C) and other shell commands, so you can stop a command in the interactive process you ran it. However, they only work if the containing shell (the one where you ran `docker run`) is also interactive with a tty hooked up, so we test for that first in both scripts that invoke `docker run`, using `test -t`. --init passes signals from *outside* Docker down to its subprocesses, so that cancellation from *another* context works for our Docker images. This includes the Cancel button in GitHub Actions.
2022-08-23 21:42:03 +02:00
IS_TTY=""
if [[ -t 0 ]]; then
IS_TTY="yes"
fi
Use Docker's ADD command for remote resources
2024-06-21 02:35:29 +02:00
docker build --build-arg "UID=${UID:-501}" --build-arg "GID=${GID:-501}" --build-arg "NODE_VERSION=$(cat .nvmrc)" -t ${DOCKER_IMAGE} -f node/Dockerfile .
GitHub: Build Ubuntu Node releases using Docker, for Ubuntu 16 compat The only supported way to target an older glibc is to build against that glibc; consequently, we need to build on an Ubuntu 16 system (or similar) to target Ubuntu 16. This requires downloading second-party versions of Clang and CMake, which are too old in the default Ubuntu repository, as well as building our own Python. Do all this in a new Dockerfile based on Ubuntu 16.04. This isn't as rigorous as the Java "reproducible build" Dockerfile, since we're not pinning the base image or the repositories we're fetching from, but it's still an image with the environment and tools we need.
2022-08-02 00:11:51 +02:00
# We build both architectures in the same run action to save on intermediates
# (including downloading dependencies)
Node: Specifically build with prebuildify@^5 prebuildify 6.0.0, just released, changed the name of the built module, which our locked version of node-gyp-build then couldn't find. By specifying a version in package.json and making sure we always `yarn install` before running prebuildify, we'll use the version from our lockfile, and never accidentally update to a new major version.
2024-01-11 01:14:40 +01:00
# We run `yarn install` to make sure the correct prebuildify version is used.
Docker: Use -it and --init to handle SIGTERM (^C) properly -i (interactive) and -t (allocate a tty) allow the shell running inside Docker to handle Ctrl-C (^C) and other shell commands, so you can stop a command in the interactive process you ran it. However, they only work if the containing shell (the one where you ran `docker run`) is also interactive with a tty hooked up, so we test for that first in both scripts that invoke `docker run`, using `test -t`. --init passes signals from *outside* Docker down to its subprocesses, so that cancellation from *another* context works for our Docker images. This includes the Cancel button in GitHub Actions.
2022-08-23 21:42:03 +02:00
docker run ${IS_TTY:+ -it} --init --rm -v "${PWD}":/home/libsignal/src ${DOCKER_IMAGE} sh -c '
GitHub: Build Ubuntu Node releases using Docker, for Ubuntu 16 compat The only supported way to target an older glibc is to build against that glibc; consequently, we need to build on an Ubuntu 16 system (or similar) to target Ubuntu 16. This requires downloading second-party versions of Clang and CMake, which are too old in the default Ubuntu repository, as well as building our own Python. Do all this in a new Dockerfile based on Ubuntu 16.04. This isn't as rigorous as the Java "reproducible build" Dockerfile, since we're not pinning the base image or the repositories we're fetching from, but it's still an image with the environment and tools we need.
2022-08-02 00:11:51 +02:00
cd ~/src/node &&
node: Remove "install" script that invokes node-gyp-build - For local development, this built the Rust library automatically when you invoked `yarn install`, whether you wanted it to or not. - For the published package, this either did nothing (if the correct prebuilds were present) or produced a weird error (if they weren't). You can't use the published package without prebuilds, so maybe this was useful, but you'd find that out pretty quickly when loading the module failed. - If you used the "link" feature to build Signal Desktop with a local checkout of libsignal, this would build the Rust library automatically when you `install`ed in the *Desktop* directory, whether you wanted it to or not. - If you pointed Signal Desktop at a local checkout by copy instead of link, this would just fail, because the Rust parts wouldn't be copied with it. Overall, it's simpler to just have this step be explicit.
2024-07-10 02:13:40 +02:00
npx yarn install --frozen-lockfile &&
GitHub: Build Ubuntu Node releases using Docker, for Ubuntu 16 compat The only supported way to target an older glibc is to build against that glibc; consequently, we need to build on an Ubuntu 16 system (or similar) to target Ubuntu 16. This requires downloading second-party versions of Clang and CMake, which are too old in the default Ubuntu repository, as well as building our own Python. Do all this in a new Dockerfile based on Ubuntu 16.04. This isn't as rigorous as the Java "reproducible build" Dockerfile, since we're not pinning the base image or the repositories we're fetching from, but it's still an image with the environment and tools we need.
2022-08-02 00:11:51 +02:00
env CARGO_TARGET_AARCH64_UNKNOWN_LINUX_GNU_LINKER=aarch64-linux-gnu-gcc \
CC=aarch64-linux-gnu-gcc \
CXX=aarch64-linux-gnu-g++ \
CPATH=/usr/aarch64-linux-gnu/include \
Use Docker's ADD command for remote resources
2024-06-21 02:35:29 +02:00
npx prebuildify --napi -t $(cat ../.nvmrc) --arch arm64 &&
node: Attach debug info to the GitHub Release
2024-06-22 00:55:20 +02:00
mv build/Release/*-debuginfo.* . &&
npx prebuildify --napi -t $(cat ../.nvmrc) --arch x64 &&
mv build/Release/*-debuginfo.* .
GitHub: Build Ubuntu Node releases using Docker, for Ubuntu 16 compat The only supported way to target an older glibc is to build against that glibc; consequently, we need to build on an Ubuntu 16 system (or similar) to target Ubuntu 16. This requires downloading second-party versions of Clang and CMake, which are too old in the default Ubuntu repository, as well as building our own Python. Do all this in a new Dockerfile based on Ubuntu 16.04. This isn't as rigorous as the Java "reproducible build" Dockerfile, since we're not pinning the base image or the repositories we're fetching from, but it's still an image with the environment and tools we need.
2022-08-02 00:11:51 +02:00
'
Copy Permalink