From 2a2ef524d2aa988aec37b16d5bce95c9e00ae0b1 Mon Sep 17 00:00:00 2001 From: Jordan Rose Date: Thu, 20 Jun 2024 17:49:26 -0700 Subject: [PATCH] Update to Node 20.11.1 --- .github/workflows/npm.yml | 4 ---- .github/workflows/slow_tests.yml | 2 -- .nvmrc | 2 +- node/package.json | 2 +- node/yarn.lock | 10 ++++++---- 5 files changed, 8 insertions(+), 12 deletions(-) diff --git a/.github/workflows/npm.yml b/.github/workflows/npm.yml index 4d63dea5..fbc234e0 100644 --- a/.github/workflows/npm.yml +++ b/.github/workflows/npm.yml @@ -30,8 +30,6 @@ jobs: arm64-rust-target: aarch64-apple-darwin - os: windows-latest arm64-rust-target: aarch64-pc-windows-msvc - # This can be removed when we update to a Node version that officially supports win-arm64. - custom-arm64-dist-url: https://unofficial-builds.nodejs.org/download/release # Ubuntu binaries are built using Docker, below timeout-minutes: 45 @@ -84,8 +82,6 @@ jobs: - name: Build for arm64 run: npx prebuildify --napi -t ${{ steps.get-nvm-version.outputs.node-version }} --arch arm64 working-directory: node - env: - npm_config_dist_url: ${{ matrix.custom-arm64-dist-url }} - name: Build for the host (should be x64) run: npx prebuildify --napi -t ${{ steps.get-nvm-version.outputs.node-version }} diff --git a/.github/workflows/slow_tests.yml b/.github/workflows/slow_tests.yml index 1ca46588..8182e529 100644 --- a/.github/workflows/slow_tests.yml +++ b/.github/workflows/slow_tests.yml @@ -224,8 +224,6 @@ jobs: - name: Build for arm64 run: npx prebuildify --napi -t ${{ steps.get-nvm-version.outputs.node-version }} --arch arm64 working-directory: node - env: - npm_config_dist_url: https://unofficial-builds.nodejs.org/download/release swift-cocoapod: name: Swift CocoaPod (all architectures) diff --git a/.nvmrc b/.nvmrc index 55bffd62..2dbbe00e 100644 --- a/.nvmrc +++ b/.nvmrc @@ -1 +1 @@ -18.15.0 +20.11.1 diff --git a/node/package.json b/node/package.json index c58c9593..07a4a991 100644 --- a/node/package.json +++ b/node/package.json @@ -39,7 +39,7 @@ "@types/chai-as-promised": "^7.1.3", "@types/chance": "^1.1.3", "@types/mocha": "^5.2.7", - "@types/node": "~18.15.0", + "@types/node": "~20.11.0", "@types/sinon": "^17.0.3", "@types/sinon-chai": "^3.2.12", "@types/uuid": "^8.3.0", diff --git a/node/yarn.lock b/node/yarn.lock index cf1ebd0a..399edf4b 100644 --- a/node/yarn.lock +++ b/node/yarn.lock @@ -211,10 +211,12 @@ dependencies: undici-types "~5.26.4" -"@types/node@~18.15.0": - version "18.15.13" - resolved "https://registry.yarnpkg.com/@types/node/-/node-18.15.13.tgz#f64277c341150c979e42b00e4ac289290c9df469" - integrity sha512-N+0kuo9KgrUQ1Sn/ifDXsvg0TTleP7rIy4zOBGECxAljqvqfqpTfzx0Q1NUedOixRMBfe2Whhb056a42cWs26Q== +"@types/node@~20.11.0": + version "20.11.30" + resolved "https://registry.yarnpkg.com/@types/node/-/node-20.11.30.tgz#9c33467fc23167a347e73834f788f4b9f399d66f" + integrity sha512-dHM6ZxwlmuZaRmUPfv1p+KrdD1Dci04FbdEm/9wEMouFqxYoFl5aMkt0VMAUtYRQDyYvD41WJLukhq/ha3YuTw== + dependencies: + undici-types "~5.26.4" "@types/semver@^7.3.12": version "7.5.6"