mirror of
https://github.com/signalapp/libsignal.git
synced 2024-09-19 19:42:19 +02:00
Add flake8 for checking our Python scripts
We only have one for now, but we can start enforcing this now.
This commit is contained in:
parent
4bee29760a
commit
77a5451c1f
6
.flake8
Normal file
6
.flake8
Normal file
@ -0,0 +1,6 @@
|
|||||||
|
[flake8]
|
||||||
|
ignore =
|
||||||
|
# E501 line too long
|
||||||
|
E501,
|
||||||
|
# E741 ambiguous variable name
|
||||||
|
E741,
|
@ -1,19 +1,22 @@
|
|||||||
name: Shellcheck
|
name: Lints
|
||||||
# This is in a separate job because we have shell scripts scattered across all our targets,
|
# This is in a separate job because we have shell scripts scattered across all our targets,
|
||||||
# *and* some of them have common dependencies.
|
# *and* some of them have common dependencies.
|
||||||
|
|
||||||
on:
|
on:
|
||||||
push:
|
push:
|
||||||
branches: [ master ]
|
branches: [ master ]
|
||||||
paths: ['**/*.sh']
|
paths: ['**/*.sh', '**/*.py']
|
||||||
pull_request:
|
pull_request:
|
||||||
branches: [ master ]
|
paths: ['**/*.sh', '**/*.py']
|
||||||
paths: ['**/*.sh']
|
|
||||||
|
|
||||||
jobs:
|
jobs:
|
||||||
build:
|
lint:
|
||||||
|
name: Check helper scripts
|
||||||
|
|
||||||
runs-on: ubuntu-latest
|
runs-on: ubuntu-latest
|
||||||
|
|
||||||
steps:
|
steps:
|
||||||
- uses: actions/checkout@v2
|
- uses: actions/checkout@v2
|
||||||
|
- run: pip3 install flake8
|
||||||
- run: shellcheck **/*.sh
|
- run: shellcheck **/*.sh
|
||||||
|
- run: python3 -m flake8 .
|
@ -19,7 +19,7 @@ cbindgen = subprocess.Popen(['cbindgen'], cwd=os.path.join(our_abs_dir, '..'), s
|
|||||||
stdout = str(stdout.decode('utf8'))
|
stdout = str(stdout.decode('utf8'))
|
||||||
stderr = str(stderr.decode('utf8'))
|
stderr = str(stderr.decode('utf8'))
|
||||||
|
|
||||||
ignore_this_warning = re.compile("WARN: Can't find .*\. This usually means that this type was incompatible or not found\.")
|
ignore_this_warning = re.compile(r"WARN: Can't find .*\. This usually means that this type was incompatible or not found\.")
|
||||||
|
|
||||||
unknown_warning = False
|
unknown_warning = False
|
||||||
|
|
||||||
@ -36,7 +36,8 @@ for l in stderr.split('\n'):
|
|||||||
if unknown_warning:
|
if unknown_warning:
|
||||||
sys.exit(1)
|
sys.exit(1)
|
||||||
|
|
||||||
java_decl = re.compile('([a-zA-Z]+) Java_org_signal_client_internal_Native_([A-Z][a-zA-Z]+)_1([A-Za-z0-9]+)\(JNIEnv .?env, JClass class_(, .*)?\);')
|
java_decl = re.compile(r'([a-zA-Z]+) Java_org_signal_client_internal_Native_([A-Z][a-zA-Z]+)_1([A-Za-z0-9]+)\(JNIEnv .?env, JClass class_(, .*)?\);')
|
||||||
|
|
||||||
|
|
||||||
def translate_to_java(typ):
|
def translate_to_java(typ):
|
||||||
# jobject is not given here; instead use a type
|
# jobject is not given here; instead use a type
|
||||||
@ -60,6 +61,7 @@ def translate_to_java(typ):
|
|||||||
|
|
||||||
raise Exception("Don't know what to do with a", typ)
|
raise Exception("Don't know what to do with a", typ)
|
||||||
|
|
||||||
|
|
||||||
cur_type = None
|
cur_type = None
|
||||||
decls = []
|
decls = []
|
||||||
|
|
||||||
@ -82,7 +84,7 @@ for line in stdout.split('\n'):
|
|||||||
java_ret_type = translate_to_java(ret_type)
|
java_ret_type = translate_to_java(ret_type)
|
||||||
java_args = []
|
java_args = []
|
||||||
|
|
||||||
if args != None:
|
if args is not None:
|
||||||
for arg in args.split(', ')[1:]:
|
for arg in args.split(', ')[1:]:
|
||||||
(arg_type, arg_name) = arg.split(' ')
|
(arg_type, arg_name) = arg.split(' ')
|
||||||
java_arg_type = translate_to_java(arg_type)
|
java_arg_type = translate_to_java(arg_type)
|
||||||
@ -102,4 +104,3 @@ if not os.access(native_java, os.F_OK):
|
|||||||
fh = open(native_java, 'w')
|
fh = open(native_java, 'w')
|
||||||
fh.write(contents)
|
fh.write(contents)
|
||||||
fh.close()
|
fh.close()
|
||||||
|
|
||||||
|
Loading…
Reference in New Issue
Block a user