mirror/libsignal
0
0
Fork 0
mirror of https://github.com/signalapp/libsignal.git synced 2024-09-19 19:42:19 +02:00
Code

swift: Remove workaround in tests for building with an old Xcode

Browse Source
This commit is contained in:
Jordan Rose 2024-08-29 16:33:49 -07:00
parent de90d87c7c
commit b67766d81e
1 changed files with 0 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
swift/Tests/LibSignalClientTests/ChatServiceTests.swift
View File

@ -360,20 +360,4 @@ final class ChatServiceTests: TestCaseBase {
// Okay
}
}
// swiftlint:disable:next todo
// TODO: Remove this when we update our builder to have Xcode 14.3 or later.
// We're shadowing the real XCTestCase.fulfillment(of:timeout:enforceOrder:) with an ad-hoc implementation from
// https://github.com/swiftlang/swift-corelibs-xctest/issues/436#issuecomment-1703589930
func fulfillment(of expectations: [XCTestExpectation], timeout seconds: TimeInterval = .infinity) async {
return await withCheckedContinuation { continuation in
// This function operates by blocking a background thread instead of one owned by libdispatch or by the
// Swift runtime (as used by Swift concurrency.) To ensure we use a thread owned by neither subsystem, use
// Foundation's Thread.detachNewThread(_:).
Thread.detachNewThread { [self] in
wait(for: expectations, timeout: seconds)
continuation.resume()
}
}
}
}