This replaces the recipient ID, which is a weak logical reference to external
data, with one of two types, depending on the mode. For streaming validation,
only the minimal data is kept. For validation via the CLI or (soon) for
canonicalization, the full data is kept behind an Arc.
Unlike Java, just bundle it into the exiting signal_node shared library. We
don't care as much about code size here and splitting it into a separate
library is significantly more complicated (though it might be worth it some
day).
- For local development, this built the Rust library automatically
when you invoked `yarn install`, whether you wanted it to or not.
- For the published package, this either did nothing (if the correct
prebuilds were present) or produced a weird error (if they weren't).
You can't use the published package without prebuilds, so maybe this
was useful, but you'd find that out pretty quickly when loading the
module failed.
- If you used the "link" feature to build Signal Desktop with a local
checkout of libsignal, this would build the Rust library
automatically when you `install`ed in the *Desktop* directory,
whether you wanted it to or not.
- If you pointed Signal Desktop at a local checkout by copy instead of
link, this would just fail, because the Rust parts wouldn't be
copied with it.
Overall, it's simpler to just have this step be explicit.
The main benefit of this is not our *own* type-checking; it's that
mypy will error out if you try to use a too-new Python API. And in
fact, we were already relying on Python 3.9 and didn't realize.
check_code_size.py works with JSON, so it still uses Any a fair bit.
This parallels the exiting libsignal-jni crate but exports functions from
libsignal-bridge-testing instead of libsignal-bridge. The crate is compiled as
a separate shared object that is included in the published libsignal package,
but which can be excluded at Android packaging time.
Remove the special handling code that detects EOF now that the upstream crate
has fixed the bug that was being worked around. This also fixes a bug where EOF
was being incorrectly detected when the provided buffer was empty. Add a test
case to prevent regression in the future.
No behavior change, just moving code into named functions to improve
readability and maintainability, and applying some Python conventions.
Co-authored-by: moiseev-signal <122060238+moiseev-signal@users.noreply.github.com>
Separate `libsignal-bridge` into two crates:
- `libsignal-bridge-types`, which contains types and methods for bridging,
declares conversion traits, and implements those traits
- `libsignal-bridge`, which defines `extern "C"` functions that get exported
into the app-language libraries
This will allow creating a second test-only crate, parallel to
`libsignal-bridge`, that can use the same types and macros for exporting
functions.
Now there's a trait, FfiError, which handles conversion to a string
and numeric code, and a helper struct SignalFfiError that mostly just
wraps `Box<dyn FfiError>`. This makes it easier to add new errors --
they only need to be added in two places (a trait impl and possibly
new error codes) instead of three.
