From 1225bcbd4112d2f5880c7273f90f56725123fe8a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kacper=20Michaj=C5=82ow?= Date: Sun, 23 Jun 2024 22:36:19 +0200 Subject: [PATCH] fuzzer_set_property: don't run mpv if set property failed We can avoid testing this cases, hopefully there are no side-effects when set property fails. --- fuzzers/fuzzer_set_property.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/fuzzers/fuzzer_set_property.c b/fuzzers/fuzzer_set_property.c index 60edc91add..8ba76cf70d 100644 --- a/fuzzers/fuzzer_set_property.c +++ b/fuzzers/fuzzer_set_property.c @@ -67,12 +67,16 @@ int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size) check_error(mpv_initialize(ctx)); #endif + int ret; if (MPV_FORMAT == MPV_FORMAT_STRING) { - mpv_set_property_string(ctx, name, (void *)data); + ret = mpv_set_property_string(ctx, name, (void *)data); } else { - mpv_set_property(ctx, name, MPV_FORMAT, (void *)data); + ret = mpv_set_property(ctx, name, MPV_FORMAT, (void *)data); } + if (ret != MPV_ERROR_SUCCESS) + return 0; + #if MPV_RUN check_error(mpv_set_option_string(ctx, "ao-null-untimed", "yes")); check_error(mpv_set_option_string(ctx, "untimed", "yes"));