0
0
mirror of https://github.com/mpv-player/mpv.git synced 2024-09-20 12:02:23 +02:00
mpv/options
Avi Halachmi (:avih) ef1d0b2cdb options: win32: ignore and deprecate --fit-border
The accurate description of this option was:
- fit-border is enabled by default. When disabled, it adds a bug where
  if the window has borders and mpv shrinks it to fit the desktop, then
  the calculation ignores the borders and adds incorrect video crop.

The option was added at commits 70f64f3c and 949247d6, in order to
solve an issue (#2935) where if mpv wanted to display a video with
size WxH, then w32_common.c incorrectly set the window to WxH, while
down-scaling the video slightly to fit (even with small sizes).

It was addressed with a new option which is enabled by default, but
does the right thing (sets the client area to WxH) only when disabled,
so that everyone who prefers their video slightly downscaled could
keep their default behavior.

(#2935 also addressed an off-by-one issue, fixed before fit-border)

While disabling the option did avoid unnecessary downscaling, it also
added a bug when disabled: the borders are no longer taken into
account when the size is too big for the desktop. Most users don't
notice and are unaffected as it's enabled by default.

Shortly later (981048e0) the core issue is fixed, and now the client
area is correctly set to WxH instead of the window (and together with
the three following commits which center the video, adds a new bug
where the window title can be outside the display - addressed next).

However, fit-border remained, now without any effect, except that it
still has the same bug when disabled and the window is too big.

Later code changes and refactoring preserved this issue with great
attention to details, and it remained in identical form until now.

Simply rip out fit-border.
2021-04-23 10:45:51 +03:00
..
m_config_core.c options: more pushing code around 2020-03-13 16:50:27 +01:00
m_config_core.h options: more pushing code around 2020-03-13 16:50:27 +01:00
m_config_frontend.c options: add some way to more or less "unapply" profiles 2020-08-07 19:41:56 +02:00
m_config_frontend.h options: add some way to more or less "unapply" profiles 2020-08-07 19:41:56 +02:00
m_config.h options: split m_config.c/h 2020-03-13 16:50:27 +01:00
m_option.c options: Make validation and help possible for all option types 2021-03-28 19:46:27 +03:00
m_option.h options: Add validation macro for int type 2021-03-28 19:46:32 +03:00
m_property.c command: disable edition switching if there are no editions 2020-03-14 01:32:27 +01:00
m_property.h command: move property multiply code to m_property.c 2018-03-26 19:47:08 +02:00
options.c options: win32: ignore and deprecate --fit-border 2021-04-23 10:45:51 +03:00
options.h player: add --screen-name and --fs-screen-name 2020-12-06 17:36:43 +00:00
parse_commandline.c options: split m_config.c/h 2020-03-13 16:50:27 +01:00
parse_commandline.h player: get rid of mpv_global.opts 2018-05-24 19:56:35 +02:00
parse_configfile.c options: add some way to more or less "unapply" profiles 2020-08-07 19:41:56 +02:00
parse_configfile.h options: split m_config.c/h 2020-03-13 16:50:27 +01:00
path.c path: do not use old_home for win32 exe dir 2020-11-16 00:44:40 +02:00
path.h path: add mp_path_is_absolute() 2020-02-06 14:14:35 +01:00