mirror of
https://github.com/mpv-player/mpv.git
synced 2024-09-20 20:03:10 +02:00
fc04be708c
vo_opengl creates a hidden X11 window to probe the OpenGL context. It must do that before creating a visible window, because VO creation and VO config are separate phases. There's a race condition involving the hidden window: when starting with --fs, and then leaving fullscreen, the unfullscreened window is sometimes set to the aspect ratio of the hidden window. I'm not sure why the window size itself uses the correct size (but corrupted by the wrong aspect), but that's perhaps because the window manager is free to ignore the size hint while honoring the aspect, or something equally messed up. It turns out this happens because x11_common.c thinks the size of the hidden window is the size of the unfullscreened window. This in turn happens because vo_x11_update_geometry() reads the size of the hidden window when called in vo_x11_fullscreen() (called from vo_x11_config_vo_window()) when mapping the fullscreen window. At that point, the window could be mapped, but not necessarily. If it's not mapped, it will get the size of the unfullscreened window... I think. One could fix this by actively waiting until the window is mapped. Try to pick a less hacky approach instead, and never read the window size until MapNotify is received. vo_x11_create_window() needs a hack, because we'd possibly set the VO's size to 0, resulting e.g. in vdpau to fail initialization. (It'll print error messages until a proper resize is received.) |
||
|---|---|---|
| .. | ||
| cocoa | ||
| aspect.c | ||
| aspect.h | ||
| bitmap_packer.c | ||
| bitmap_packer.h | ||
| cocoa_common.h | ||
| cocoa_common.m | ||
| d3d_shader_yuv.h | ||
| d3d_shader_yuv.hlsl | ||
| dither.c | ||
| dither.h | ||
| filter_kernels.c | ||
| filter_kernels.h | ||
| gl_cocoa.c | ||
| gl_common.c | ||
| gl_common.h | ||
| gl_header_fixes.h | ||
| gl_hwdec_vaglx.c | ||
| gl_hwdec_vda.c | ||
| gl_hwdec_vdpau.c | ||
| gl_lcms.c | ||
| gl_lcms.h | ||
| gl_osd.c | ||
| gl_osd.h | ||
| gl_video_shaders.glsl | ||
| gl_video.c | ||
| gl_video.h | ||
| gl_w32.c | ||
| gl_wayland.c | ||
| gl_x11.c | ||
| pnm_loader.c | ||
| pnm_loader.h | ||
| vo_caca.c | ||
| vo_corevideo.c | ||
| vo_direct3d.c | ||
| vo_image.c | ||
| vo_lavc.c | ||
| vo_null.c | ||
| vo_opengl_old.c | ||
| vo_opengl.c | ||
| vo_sdl.c | ||
| vo_vaapi.c | ||
| vo_vdpau.c | ||
| vo_wayland.c | ||
| vo_x11.c | ||
| vo_xv.c | ||
| vo.c | ||
| vo.h | ||
| w32_common.c | ||
| w32_common.h | ||
| wayland_common.c | ||
| wayland_common.h | ||
| x11_common.c | ||
| x11_common.h | ||
| x11_icon.bin | ||