From 184f6f38fb0d7e8432527c34078f057e8c6da242 Mon Sep 17 00:00:00 2001 From: PatTheMav Date: Thu, 17 Mar 2022 21:21:40 +0100 Subject: [PATCH] CI: Fix CMake definition of streaming service options On master branch, client information for Twitch, YouTube and Restream integration are set as CMake cache variables. The hashes can contain otherwise "illegal" characters such as backticks which need to be enclosed in a string, but also cannot be subject to variable substition. Using single quotes should fix this. --- CI/linux/02_build_obs.sh | 8 ++++---- CI/macos/02_build_obs.sh | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/CI/linux/02_build_obs.sh b/CI/linux/02_build_obs.sh index b7006609a..6f4fa523b 100755 --- a/CI/linux/02_build_obs.sh +++ b/CI/linux/02_build_obs.sh @@ -33,16 +33,16 @@ _configure_obs() { trap "caught_error 'configure build'" ERR check_ccache - if [ "${TWITCH_CLIENTID}" -a "${TWICH_HASH}" ]; then - TWITCH_OPTIONS="-DTWITCH_CLIENTID=\"${TWITCH_CLIENTID}\" -DTWITCH_HASH=\"${TWITCH_HASH}\"" + if [ "${TWITCH_CLIENTID}" -a "${TWITCH_HASH}" ]; then + TWITCH_OPTIONS="-DTWITCH_CLIENTID='${TWITCH_CLIENTID}' -DTWITCH_HASH='${TWITCH_HASH}'" fi if [ "${RESTREAM_CLIENTID}" -a "${RESTREAM_HASH}" ]; then - RESTREAM_OPTIONS="-DRESTREAM_CLIENTID=\"${RESTREAM_CLIENTID}\" -DRESTREAM_HASH=\"${RESTREAM_HASH}\"" + RESTREAM_OPTIONS="-DRESTREAM_CLIENTID='${RESTREAM_CLIENTID}' -DRESTREAM_HASH='${RESTREAM_HASH}'" fi if [ "${YOUTUBE_CLIENTID}" -a "${YOUTUBE_CLIENTID_HASH}" -a "${YOUTUBE_SECRET}" -a "{YOUTUBE_SECRET_HASH}" ]; then - YOUTUBE_OPTIONS="-DYOUTUBE_CLIENTID=\"${YOUTUBE_CLIENTID}\" -DYOUTUBE_CLIENTID_HASH=\"${YOUTUBE_CLIENTID_HASH}\" -DYOUTUBE_SECRET=\"${YOUTUBE_SECRET}\" -DYOUTUBE_SECRET_HASH=\"${YOUTUBE_SECRET_HASH}\"" + YOUTUBE_OPTIONS="-DYOUTUBE_CLIENTID='${YOUTUBE_CLIENTID}' -DYOUTUBE_CLIENTID_HASH='${YOUTUBE_CLIENTID_HASH}' -DYOUTUBE_SECRET='${YOUTUBE_SECRET}' -DYOUTUBE_SECRET_HASH='${YOUTUBE_SECRET_HASH}'" fi if [ "${PORTABLE}" ]; then diff --git a/CI/macos/02_build_obs.sh b/CI/macos/02_build_obs.sh index 5fcea868d..073faa332 100755 --- a/CI/macos/02_build_obs.sh +++ b/CI/macos/02_build_obs.sh @@ -47,16 +47,16 @@ _configure_obs() { trap "caught_error 'configure build'" ERR check_ccache - if [ "${TWITCH_CLIENTID}" -a "${TWICH_HASH}" ]; then - TWITCH_OPTIONS="-DTWITCH_CLIENTID=\"${TWITCH_CLIENTID}\" -DTWITCH_HASH=\"${TWITCH_HASH}\"" + if [ "${TWITCH_CLIENTID}" -a "${TWITCH_HASH}" ]; then + TWITCH_OPTIONS="-DTWITCH_CLIENTID='${TWITCH_CLIENTID}' -DTWITCH_HASH='${TWITCH_HASH}'" fi if [ "${RESTREAM_CLIENTID}" -a "${RESTREAM_HASH}" ]; then - RESTREAM_OPTIONS="-DRESTREAM_CLIENTID=\"${RESTREAM_CLIENTID}\" -DRESTREAM_HASH=\"${RESTREAM_HASH}\"" + RESTREAM_OPTIONS="-DRESTREAM_CLIENTID='${RESTREAM_CLIENTID}' -DRESTREAM_HASH='${RESTREAM_HASH}'" fi if [ "${YOUTUBE_CLIENTID}" -a "${YOUTUBE_CLIENTID_HASH}" -a "${YOUTUBE_SECRET}" -a "{YOUTUBE_SECRET_HASH}" ]; then - YOUTUBE_OPTIONS="-DYOUTUBE_CLIENTID=\"${YOUTUBE_CLIENTID}\" -DYOUTUBE_CLIENTID_HASH=\"${YOUTUBE_CLIENTID_HASH}\" -DYOUTUBE_SECRET=\"${YOUTUBE_SECRET}\" -DYOUTUBE_SECRET_HASH=\"${YOUTUBE_SECRET_HASH}\"" + YOUTUBE_OPTIONS="-DYOUTUBE_CLIENTID='${YOUTUBE_CLIENTID}' -DYOUTUBE_CLIENTID_HASH='${YOUTUBE_CLIENTID_HASH}' -DYOUTUBE_SECRET='${YOUTUBE_SECRET}' -DYOUTUBE_SECRET_HASH='${YOUTUBE_SECRET_HASH}'" fi if [ "${XCODE}" ]; then