mirror/obs-studio
0
0
Fork 0
mirror of https://github.com/obsproject/obs-studio.git synced 2024-09-19 20:32:15 +02:00
Code

mac-videotoolbox: Set default keyframe interval to 2 seconds

Browse Source 
0 seconds means "auto" according to the documentation, but this appears
to be broken in many configurations (more than just CRF mode on Apple
Silicon). With some encoders it means that the encoder sets a keyframes
every 31st frame, other times it just doesn't set any keyframes at all
after the first one, only rarely does the "auto" interval actually
appear to work.
Lets just set the default to 2 seconds and be happy. In theory this is
the maximum keyframe interval and encoders are allowed to set more if
they so wish, but they never appear to do so.
This commit is contained in:
gxalpha 2023-08-28 16:34:46 +02:00 committed by Lain
parent 24073568e5
commit 5cd30d6a86
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
plugins/mac-videotoolbox/encoder.c
View File

@ -1540,7 +1540,7 @@ static void vt_defaults(obs_data_t *settings, void *data)
obs_data_set_default_bool(settings, "limit_bitrate", false);
obs_data_set_default_int(settings, "max_bitrate", 2500);
obs_data_set_default_double(settings, "max_bitrate_window", 1.5f);
obs_data_set_default_int(settings, "keyint_sec", 0);
obs_data_set_default_int(settings, "keyint_sec", 2);
obs_data_set_default_string(
settings, "profile",
type_data->codec_type == kCMVideoCodecType_H264 ? "high"