mirror/obs-studio
0
0
Fork 0
mirror of https://github.com/obsproject/obs-studio.git synced 2024-09-20 13:08:50 +02:00
Code

UI: Use emplace_back instead of push_back + move

Browse Source 
Found by clang-3.7 (trunk 236075) via -Wpessimizing-move
This commit is contained in:
Palana 2015-05-09 01:12:40 +02:00
parent 851d13e910
commit 7900f46e77
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
obs/properties-view.cpp
View File

@ -169,7 +169,7 @@ QWidget *OBSPropertiesView::NewWidget(obs_property_t *prop, QWidget *widget,
{
WidgetInfo *info = new WidgetInfo(this, prop, widget);
connect(widget, signal, info, SLOT(ControlChanged()));
children.push_back(std::move(unique_ptr<WidgetInfo>(info)));
children.emplace_back(info);
return widget;
}
@ -222,7 +222,7 @@ void OBSPropertiesView::AddPath(obs_property_t *prop, QFormLayout *layout,
WidgetInfo *info = new WidgetInfo(this, prop, edit);
connect(button, SIGNAL(clicked()), info, SLOT(ControlChanged()));
children.push_back(std::move(unique_ptr<WidgetInfo>(info)));
children.emplace_back(info);
*label = new QLabel(QT_UTF8(obs_property_description(prop)));
layout->addRow(*label, subLayout);
@ -248,7 +248,7 @@ void OBSPropertiesView::AddInt(obs_property_t *prop, QFormLayout *layout,
spin->setValue(val);
WidgetInfo *info = new WidgetInfo(this, prop, spin);
children.push_back(std::move(unique_ptr<WidgetInfo>(info)));
children.emplace_back(info);
if (type == OBS_NUMBER_SLIDER) {
QSlider *slider = new QSlider();
@ -293,7 +293,7 @@ void OBSPropertiesView::AddFloat(obs_property_t *prop, QFormLayout *layout,
spin->setValue(val);
WidgetInfo *info = new WidgetInfo(this, prop, spin);
children.push_back(std::move(unique_ptr<WidgetInfo>(info)));
children.emplace_back(info);
if (type == OBS_NUMBER_SLIDER) {
DoubleSlider *slider = new DoubleSlider();
@ -438,7 +438,7 @@ QWidget *OBSPropertiesView::AddList(obs_property_t *prop, bool &warning)
WidgetInfo *info = new WidgetInfo(this, prop, combo);
connect(combo, SIGNAL(currentIndexChanged(int)), info,
SLOT(ControlChanged()));
children.push_back(std::move(unique_ptr<WidgetInfo>(info)));
children.emplace_back(info);
/* trigger a settings update if the index was not found */
if (idx == -1)