0
0
mirror of https://github.com/obsproject/obs-studio.git synced 2024-09-20 13:08:50 +02:00

obs-vst: Fix memory leaks on macOS when VST's fail to load

Detected by clang-analyzer.
This commit is contained in:
gxalpha 2023-03-08 03:27:54 +01:00 committed by Ryan Foster
parent 9d4a7f01dd
commit 9c6a3a1d49

View File

@ -30,6 +30,7 @@ AEffect *VSTPlugin::loadEffect()
true);
if (bundleUrl == NULL) {
CFRelease(pluginPathStringRef);
blog(LOG_WARNING,
"Couldn't make URL reference for VST plug-in");
return NULL;
@ -58,6 +59,8 @@ AEffect *VSTPlugin::loadEffect()
if (mainEntryPoint == NULL) {
blog(LOG_WARNING, "Couldn't get a pointer to plug-in's main()");
CFRelease(pluginPathStringRef);
CFRelease(bundleUrl);
CFRelease(bundle);
bundle = NULL;
return NULL;
@ -66,6 +69,8 @@ AEffect *VSTPlugin::loadEffect()
newEffect = mainEntryPoint(hostCallback_static);
if (newEffect == NULL) {
blog(LOG_WARNING, "VST Plug-in's main() returns null.");
CFRelease(pluginPathStringRef);
CFRelease(bundleUrl);
CFRelease(bundle);
bundle = NULL;
return NULL;