mirror/obs-studio
0
0
Fork 0
mirror of https://github.com/obsproject/obs-studio.git synced 2024-09-20 13:08:50 +02:00
Code

obs-ffmpeg/nvenc: Remove "default" preset

Browse Source 
The "default" preset is not an actual default, but something Nvidia
decided to just call that way.  It yields the worst quality per bitrate
out of all the presets, for no actual benefits.  The actual FFmpeg
default is the hq one, which yields the best quality, especially when
twopass mode is enabled.

I can't think of a way to keep the "default" preset in a non-confusing
way, and as it gives no known benefits, might as well just remove it
entirely.

(Jim edit: Also made it so that if the settings have it set to
"default", it automatically treats it as "hq")

Closes jp9000/obs-studio#865
This commit is contained in:
BtbN 2017-03-19 20:47:53 +01:00 committed by jp9000
parent 2b87b3af10
commit d1343dc064
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
plugins/obs-ffmpeg/obs-ffmpeg-nvenc.c
View File

@ -158,6 +158,10 @@ static bool nvenc_update(void *data, obs_data_t *settings)
rc = "CBR";
}
/* The "default" preset has been deprecated */
if (preset && astrcmpi(preset, "default") == 0)
preset = "hq";
info.format = voi->format;
info.colorspace = voi->colorspace;
info.range = voi->range;
@ -384,7 +388,7 @@ static void nvenc_defaults(obs_data_t *settings)
obs_data_set_default_int(settings, "keyint_sec", 0);
obs_data_set_default_int(settings, "cqp", 23);
obs_data_set_default_string(settings, "rate_control", "CBR");
obs_data_set_default_string(settings, "preset", "default");
obs_data_set_default_string(settings, "preset", "hq");
obs_data_set_default_string(settings, "profile", "main");
obs_data_set_default_string(settings, "level", "auto");
obs_data_set_default_bool(settings, "2pass", true);
@ -448,7 +452,6 @@ static obs_properties_t *nvenc_properties(void *unused)
#define add_preset(val) \
obs_property_list_add_string(p, obs_module_text("NVENC.Preset." val), \
val)
add_preset("default");
add_preset("hq");
add_preset("hp");
add_preset("bd");