mirror/obs-studio
0
0
Fork 0
mirror of https://github.com/obsproject/obs-studio.git synced 2024-09-20 04:42:18 +02:00
Code

obs-ffmpeg: Relax 'lookahead' constraint when bitrate is updated

Browse Source 
When bitrate is updated, a check against 'lookahead' setting is done.
If 'lookahead' is enabled, the bitrate update is disabled.
We indeed used to observe crashes with nvenc when frequent bitrate
resettings were effected while lookahead option was enabled.
But recent tests have shown that the issue is gone.
As a result this commit allows 'lookahead' with bitrate live update.

Signed-off-by: pkv <pkv@obsproject.com>
This commit is contained in:
pkv 2023-02-15 19:08:59 +01:00 committed by Ryan Foster
parent 5d1f0efc43
commit e355a32066
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
plugins/obs-ffmpeg/jim-nvenc.c
View File

@ -645,8 +645,7 @@ static bool init_encoder_base(struct nvenc_data *enc, obs_data_t *settings,
/* rate control */
enc->can_change_bitrate =
nv_get_cap(enc, NV_ENC_CAPS_SUPPORT_DYN_BITRATE_CHANGE) &&
!lookahead;
nv_get_cap(enc, NV_ENC_CAPS_SUPPORT_DYN_BITRATE_CHANGE);
config->rcParams.rateControlMode = NV_ENC_PARAMS_RC_VBR;