From e6b3ae738f2e07076928fe3fbab6676f59c9a825 Mon Sep 17 00:00:00 2001 From: TDV Alinsa Date: Wed, 25 Oct 2023 09:40:26 -0700 Subject: [PATCH] obs-webrtc: Allow non-CBR rate control with WHIP Nothing about WHIP requires CBR (and many things that use it use VBR), and there's no specific upstream service to care about it (WHIP is a protocol, not a service, despite being exposed as a "service" in OBS), so let's stop forcing it to be CBR and allow the user to choose other rate control methods. --- plugins/obs-webrtc/whip-service.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/plugins/obs-webrtc/whip-service.cpp b/plugins/obs-webrtc/whip-service.cpp index 7e73bd63d..89bb24b7c 100644 --- a/plugins/obs-webrtc/whip-service.cpp +++ b/plugins/obs-webrtc/whip-service.cpp @@ -33,7 +33,6 @@ void WHIPService::ApplyEncoderSettings(obs_data_t *video_settings, obs_data_t *) // For now, ensure maximum compatibility with webrtc peers if (video_settings) { obs_data_set_int(video_settings, "bf", 0); - obs_data_set_string(video_settings, "rate_control", "CBR"); obs_data_set_bool(video_settings, "repeat_headers", true); } }