mirror/openvpn
0
0
Fork 0
mirror of https://github.com/OpenVPN/openvpn.git synced 2024-09-20 03:52:28 +02:00
Code

Fix a null-pointer dereference in establish_http_proxy_passthru()

Browse Source 
Prevents that the client crashes if the peer does not specify
the 'realm' and/or 'nonce' values. These pointers are
dereferenced in DigestCalcHA1() and DigestCalcResponse();
hence, if not set, a null-pointer dereference would occur.

Signed-off-by: Guido Vranken <guidovranken@gmail.com>
Acked-by: Gert Doering <gert@greenie.muc.de>
Message-Id: <1497574736-2092-1-git-send-email-gv@guidovranken.nl>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg14844.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
(cherry picked from commit 14865773ad)
(cherry picked from commit 479b6d13d8)
This commit is contained in:
Guido Vranken 2017-06-16 02:58:56 +02:00 committed by Gert Doering
parent ce0f075c2c
commit 0c8cf64cc1
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
proxy.c
View File

@ -745,6 +745,12 @@ establish_http_proxy_passthru (struct http_proxy_info *p,
const char *algor = get_pa_var("algorithm", pa, &gc); const char *algor = get_pa_var("algorithm", pa, &gc);
const char *opaque = get_pa_var("opaque", pa, &gc); const char *opaque = get_pa_var("opaque", pa, &gc);
if ( !realm || !nonce )
{
msg(D_LINK_ERRORS, "HTTP proxy: digest auth failed, malformed response from server: realm= or nonce= missing" );
goto error;
}
/* generate a client nonce */ /* generate a client nonce */
ASSERT(RAND_bytes(cnonce_raw, sizeof(cnonce_raw))); ASSERT(RAND_bytes(cnonce_raw, sizeof(cnonce_raw)));
cnonce = make_base64_string2(cnonce_raw, sizeof(cnonce_raw), &gc); cnonce = make_base64_string2(cnonce_raw, sizeof(cnonce_raw), &gc);