mirror/openvpn
0
0
Fork 0
mirror of https://github.com/OpenVPN/openvpn.git synced 2024-09-20 12:02:28 +02:00
Code

xkey_pkcs11h_sign: fix dangling pointer

Browse Source 
Warning by GCC 12:
pkcs11_openssl.c:237:22: warning:
dangling pointer ‘tbs’ to ‘enc’ may be used [-Wdangling-pointer=]

Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
Acked-by: Selva Nair <selva.nair@gmail.com>
Message-Id: <20230110131947.59552-1-frank@lichtenheld.com>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg25942.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
This commit is contained in:
Frank Lichtenheld 2023-01-10 14:19:47 +01:00 committed by Gert Doering
parent ccf9d57249
commit 202b34da38
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/openvpn/pkcs11_openssl.c
View File

@ -169,6 +169,9 @@ xkey_pkcs11h_sign(void *handle, unsigned char *sig,
unsigned char buf[EVP_MAX_MD_SIZE];
size_t buflen;
unsigned char enc[EVP_MAX_MD_SIZE + 32]; /* 32 bytes enough for DigestInfo header */
size_t enc_len = sizeof(enc);
if (!strcmp(sigalg.op, "DigestSign"))
{
msg(D_XKEY, "xkey_pkcs11h_sign: computing digest");
@ -214,9 +217,6 @@ xkey_pkcs11h_sign(void *handle, unsigned char *sig,
{
/* CMA_RSA_PKCS needs pkcs1 encoded digest */
unsigned char enc[EVP_MAX_MD_SIZE + 32]; /* 32 bytes enough for DigestInfo header */
size_t enc_len = sizeof(enc);
if (!encode_pkcs1(enc, &enc_len, sigalg.mdname, tbs, tbslen))
{
return 0;