mirror/openvpn
0
0
Fork 0
mirror of https://github.com/OpenVPN/openvpn.git synced 2024-09-20 03:52:28 +02:00
Code

Fix various 'Uninitialized scalar variable' warnings from Coverity

Browse Source 
These are all not actually problems, since the
uninitialized parts are either .unused members of the
struct (mroute_addr) or only written to (buflen), but
still doesn't hurt to explicitely initialize them.

Change-Id: I45cd0917d24570ae9e9db7eb6c370756e4595842
Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
Acked-by: Arne Schwabe <arne-openvpn@rfc2549.org>
Message-Id: <20231008103641.19864-1-frank@lichtenheld.com>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27157.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
This commit is contained in:
Frank Lichtenheld 2023-10-08 12:36:41 +02:00 committed by Gert Doering
parent 4bcb38c42a
commit 327355f517
4 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/openvpn/mudp.c
View File

@ -188,7 +188,7 @@ struct multi_instance *
multi_get_create_instance_udp(struct multi_context *m, bool *floated)
{
struct gc_arena gc = gc_new();
struct mroute_addr real;
struct mroute_addr real = {0};
struct multi_instance *mi = NULL;
struct hash *hash = m->hash;

8
src/openvpn/multi.c
View File

@ -1234,7 +1234,7 @@ multi_learn_in_addr_t(struct multi_context *m,
bool primary)
{
struct openvpn_sockaddr remote_si;
struct mroute_addr addr;
struct mroute_addr addr = {0};
CLEAR(remote_si);
remote_si.addr.in4.sin_family = AF_INET;
@ -1273,7 +1273,7 @@ multi_learn_in6_addr(struct multi_context *m,
int netbits, /* -1 if host route, otherwise # of network bits in address */
bool primary)
{
struct mroute_addr addr;
struct mroute_addr addr = {0};
addr.len = 16;
addr.type = MR_ADDR_IPV6;
@ -3137,7 +3137,7 @@ multi_process_post(struct multi_context *m, struct multi_instance *mi, const uns
void
multi_process_float(struct multi_context *m, struct multi_instance *mi)
{
struct mroute_addr real;
struct mroute_addr real = {0};
struct hash *hash = m->hash;
struct gc_arena gc = gc_new();
@ -3551,7 +3551,7 @@ multi_process_incoming_tun(struct multi_context *m, const unsigned int mpp_flags
if (BLEN(&m->top.c2.buf) > 0)
{
unsigned int mroute_flags;
struct mroute_addr src, dest;
struct mroute_addr src = {0}, dest = {0};
const int dev_type = TUNNEL_TYPE(m->top.c1.tuntap);
int16_t vid = 0;

2
src/openvpn/pkcs11_openssl.c
View File

@ -166,7 +166,7 @@ xkey_pkcs11h_sign(void *handle, unsigned char *sig,
CK_RSA_PKCS_PSS_PARAMS pss_params = {0};
unsigned char buf[EVP_MAX_MD_SIZE];
size_t buflen;
size_t buflen = 0;
size_t siglen_max = *siglen;
unsigned char enc[EVP_MAX_MD_SIZE + 32]; /* 32 bytes enough for DigestInfo header */

2
src/openvpn/socket.c
View File

@ -3298,7 +3298,7 @@ link_socket_read_udp_posix_recvmsg(struct link_socket *sock,
{
struct iovec iov;
uint8_t pktinfo_buf[PKTINFO_BUF_SIZE];
struct msghdr mesg;
struct msghdr mesg = {0};
socklen_t fromlen = sizeof(from->dest.addr);
ASSERT(sock->sd >= 0); /* can't happen */