mirror/openvpn
0
0
Fork 0
mirror of https://github.com/OpenVPN/openvpn.git synced 2024-09-20 03:52:28 +02:00
Code

get_user_pass_cr: get password from stdin if missing inline

Browse Source 
Until now, when HTTP proxy user and password were specified inline,
it was assumed that both creds were specified. A missing password would
result in an empty password being stored.

This behaviour is not ideal, as we want to allow the user to store the
username, but let the password be entered via stdin.

This affects both http proxy and authentication inline'd creds.

Signed-off-by: Antonio Quartulli <a@unstable.cc>
Acked-by: Gert Doering <gert@greenie.muc.de>
Message-Id: <20220914185937.31423-2-a@unstable.cc>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg25215.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
This commit is contained in:
Antonio Quartulli 2022-09-14 20:59:37 +02:00 committed by Gert Doering
parent 7d48d31b82
commit 39619b7fab
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Changes.rst
View File

@ -95,7 +95,9 @@ Session timeout
Inline auth username and password
Username and password can now be specified inline in the configuration file
within the <auth-user-pass></auth-user-pass> tags.
within the <auth-user-pass></auth-user-pass> tags. If the password is
missing OpenVPN will prompt for input via stdin. This applies to inline'd
http-proxy-user-pass too.
Deprecated features

5
src/openvpn/misc.c
View File

@ -197,6 +197,11 @@ get_user_pass_cr(struct user_pass *up,
buf_parse(&buf, '\n', up->username, USER_PASS_LEN);
}
buf_parse(&buf, '\n', up->password, USER_PASS_LEN);
if (strlen(up->password) == 0)
{
password_from_stdin = 1;
}
}
/*
* Read from auth file unless this is a dynamic challenge request.