mirror/openvpn
0
0
Fork 0
mirror of https://github.com/OpenVPN/openvpn.git synced 2024-09-20 03:52:28 +02:00
Code

route: warn on IPv4 routes installation when no IPv4 is configured

Browse Source 
Same as already happens for IPv6, it is useful for the user to throw a
warning when an IPv4 route is about to be installed and the tun interface
has no IPv4 configured.

The twin message for IPv4 is adapted to have the same format.

The warning is not fatal, becuase the route might actually be external
to the tun interface and therefore it may still work.

At the same time, modify the error message used for a route
installation failure to explicitly mention "IPv4" since this it is
used in the IPv4 code path only.

Trac: #208
Signed-off-by: Antonio Quartulli <antonio@openvpn.net>

Acked-by: Gert Doering <gert@greenie.muc.de>
Message-Id: <20200530000600.1680-6-a@unstable.cc>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg19946.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
This commit is contained in:
Antonio Quartulli 2020-05-30 02:05:58 +02:00 committed by Gert Doering
parent 6a8cd033b1
commit 826d8953a3
1 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/openvpn/route.c
View File

@ -987,7 +987,7 @@ redirect_default_route_to_vpn(struct route_list *rl, const struct tuntap *tt,
unsigned int flags, const struct env_set *es,
openvpn_net_ctx_t *ctx)
{
const char err[] = "NOTE: unable to redirect default gateway --";
const char err[] = "NOTE: unable to redirect IPv4 default gateway --";
if (rl && rl->flags & RG_ENABLE)
{
@ -1192,6 +1192,14 @@ add_routes(struct route_list *rl, struct route_ipv6_list *rl6,
{
struct route_ipv4 *r;
if (rl->routes && !tt->did_ifconfig_setup)
{
msg(M_INFO, "WARNING: OpenVPN was configured to add an IPv4 "
"route. However, no IPv4 has been configured for %s, "
"therefore the route installation may fail or may not work "
"as expected.", tt->actual_name);
}
#ifdef ENABLE_MANAGEMENT
if (management && rl->routes)
{
@ -1223,9 +1231,9 @@ add_routes(struct route_list *rl, struct route_ipv6_list *rl6,
if (!tt->did_ifconfig_ipv6_setup)
{
msg(M_INFO, "WARNING: OpenVPN was configured to add an IPv6 "
"route over %s. However, no IPv6 has been configured for "
"this interface, therefore the route installation may "
"fail or may not work as expected.", tt->actual_name);
"route. However, no IPv6 has been configured for %s, "
"therefore the route installation may fail or may not work "
"as expected.", tt->actual_name);
}
for (r = rl6->routes_ipv6; r; r = r->next)