mirror/openvpn
0
0
Fork 0
mirror of https://github.com/OpenVPN/openvpn.git synced 2024-09-19 19:42:30 +02:00
Code

Fixed compiler warnings reported on Ubuntu 10.04

Browse Source 
The warnings reported where:
--------------------------------------------------------
misc.c:158: warning: ignoring return value of ‘nice’, declared with attribute warn_unused_result
options.c:4033: warning: format not a string literal and no format arguments
options.c:4043: warning: format not a string literal and no format arguments
options.c:4053: warning: format not a string literal and no format arguments
push.c:182: warning: format not a string literal and no format arguments
push.c:199: warning: format not a string literal and no format arguments
push.c:235: warning: format not a string literal and no format arguments
status.c:171: warning: ignoring return value of ‘ftruncate’, declared with attribute warn_unused_result
--------------------------------------------------------

Signed-off-by: David Sommerseth <dazo@users.sourceforge.net>
Acked-by: Gert Doering <gert@greenie.muc.de>
Acked-by: Peter Stuge <peter@stuge.se>
This commit is contained in:
David Sommerseth 2010-09-17 17:10:25 +02:00
parent 6f1e61b41b
commit d6b783a8ec
4 changed files with 11 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
misc.c
View File

@ -155,9 +155,8 @@ set_nice (int niceval)
{
#ifdef HAVE_NICE
errno = 0;
nice (niceval);
if (errno != 0)
msg (M_WARN | M_ERRNO, "WARNING: nice %d failed", niceval);
if (nice (niceval) < 0 && errno != 0)
msg (M_WARN | M_ERRNO, "WARNING: nice %d failed: %s", niceval, strerror(errno));
else
msg (M_INFO, "nice %d succeeded", niceval);
#else

6
options.c
View File

@ -4014,7 +4014,7 @@ add_option (struct options *options,
{
if (options->inetd != -1)
{
msg (msglevel, opterr);
msg (msglevel, "%s", opterr);
goto err;
}
else
@ -4024,7 +4024,7 @@ add_option (struct options *options,
{
if (options->inetd != -1)
{
msg (msglevel, opterr);
msg (msglevel, "%s", opterr);
goto err;
}
else
@ -4034,7 +4034,7 @@ add_option (struct options *options,
{
if (name != NULL)
{
msg (msglevel, opterr);
msg (msglevel, "%s", opterr);
goto err;
}
name = p[z];

6
push.c
View File

@ -179,7 +179,7 @@ send_push_reply (struct context *c)
const int safe_cap = BCAP (&buf) - extra;
bool push_sent = false;
buf_printf (&buf, cmd);
buf_printf (&buf, "%s", cmd);
while (e)
{
@ -196,7 +196,7 @@ send_push_reply (struct context *c)
push_sent = true;
multi_push = true;
buf_reset_len (&buf);
buf_printf (&buf, cmd);
buf_printf (&buf, "%s", cmd);
}
}
if (BLEN (&buf) + l >= safe_cap)
@ -232,7 +232,7 @@ send_push_reply (struct context *c)
bool status = false;
buf_reset_len (&buf);
buf_printf (&buf, cmd);
buf_printf (&buf, "%s", cmd);
status = send_control_channel_string (c, BSTR(&buf), D_PUSH);
if (!status)
goto fail;

4
status.c
View File

@ -168,7 +168,9 @@ status_flush (struct status_output *so)
#if defined(HAVE_FTRUNCATE)
{
const off_t off = lseek (so->fd, (off_t)0, SEEK_CUR);
ftruncate (so->fd, off);
if (ftruncate (so->fd, off) != 0) {
msg (M_WARN, "Failed to truncate status file: %s", strerror(errno));
}
}
#elif defined(HAVE_CHSIZE)
{