mirror/openvpn
0
0
Fork 0
mirror of https://github.com/OpenVPN/openvpn.git synced 2024-09-20 03:52:28 +02:00
Code

Warn user if INFO control command is too long

Browse Source 
"INFO_PRE,..." command length is limited to 256 bytes. If the server
implementation pushes command which is too long, warn the user and
don't send the truncated command to a management client.

Change-Id: If3c27a2a2ba24f2af0e3e3c95eea57ed420b2542
Signed-off-by: Lev Stipakov <lev@openvpn.net>
Acked-by: Frank Lichtenheld <frank@lichtenheld.com>
Message-Id: <20230922105055.37969-1-frank@lichtenheld.com>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27062.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
This commit is contained in:
Lev Stipakov 2023-09-22 12:50:55 +02:00 committed by Gert Doering
parent 95cc5faa16
commit df624fb6d6
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/openvpn/push.c
View File

@ -242,8 +242,14 @@ server_pushed_info(struct context *c, const struct buffer *buffer,
* for management greeting and we don't want to confuse the client
*/
struct buffer out = alloc_buf_gc(256, &gc);
buf_printf(&out, ">%s:%s", "INFOMSG", m);
management_notify_generic(management, BSTR(&out));
if (buf_printf(&out, ">%s:%s", "INFOMSG", m))
{
management_notify_generic(management, BSTR(&out));
}
else
{
msg(D_PUSH_ERRORS, "WARNING: Received INFO command is too long, won't notify management client.");
}
gc_free(&gc);
}