0
0
mirror of https://github.com/OpenVPN/openvpn3.git synced 2024-09-20 04:02:15 +02:00

Do not print the length of passwords

Reported-By: Trail of Bits (TOB-OVPN3-3)
This commit is contained in:
Arne Schwabe 2023-01-09 15:30:27 +01:00
parent 20edab8dd5
commit 03e27e8c0a

View File

@ -86,7 +86,14 @@ class AuthCreds : public RC<thread_unsafe_refcount>
std::ostringstream os;
os << "*** AuthCreds ***" << std::endl;
os << "user: '" << username << "'" << std::endl;
os << "pass: (" << password.length() << " chars)" << std::endl;
if (password.empty())
{
os << "pass: (empty)" << std::endl;
}
else
{
os << "pass: (non-empty)" << std::endl;
}
os << "peer info:" << std::endl;
os << peer_info.render(Option::RENDER_BRACKET | Option::RENDER_NUMBER);
return os.str();