mirror/openvpn3
0
0
Fork 0
mirror of https://github.com/OpenVPN/openvpn3.git synced 2024-09-20 04:02:15 +02:00
Code

proto test: retry up to 5 times to prevent errors from blowing up the test

Browse Source 
By default, the proto test uses a relatively small
handshake_window to intentionally trigger
KEV_NEGOTIATE_ERROR, so that we can test mid-session error
recovery.  However if KEV_NEGOTIATE_ERROR is hit on the
first primary key (i.e. first KeyContext with key_id == 0),
it is fatal to the session and will trigger a disconnect.

This change introduces a retry to prevent this
low-probability, false-positive corner case from
blowing up the test.

Signed-off-by: James Yonan <james@openvpn.net>
This commit is contained in:
James Yonan 2021-05-31 23:21:30 -06:00
parent e9fef02f52
commit 0670c1606b
1 changed files with 22 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
test/ssl/proto.cpp
View File

@ -125,6 +125,11 @@
#define SITER 1
#endif
// number of retries for failed test
#ifndef N_RETRIES
#define N_RETRIES 5
#endif
// abort if we reach this limit
//#define DROUGHT_LIMIT 100000
@ -1102,6 +1107,21 @@ int test(const int thread_num)
return 0;
}
int test_retry(const int thread_num)
{
const int n_retries = N_RETRIES;
int ret = 1;
for (int i = 0; i < n_retries; ++i)
{
ret = test(thread_num);
if (!ret)
return 0;
std::cout << "Retry " << (i+1) << '/' << n_retries << std::endl;
}
std::cout << "Failed" << std::endl;
return ret;
}
int main(int argc, char* argv[])
{
int ret = 0;
@ -1126,7 +1146,7 @@ int main(int argc, char* argv[])
for (i = 0; i < N_THREADS; ++i)
{
threads[i] = new std::thread([i]() {
test(i);
test_retry(i);
});
}
for (i = 0; i < N_THREADS; ++i)
@ -1135,7 +1155,7 @@ int main(int argc, char* argv[])
delete threads[i];
}
#else
ret = test(1);
ret = test_retry(1);
#endif
out: