mirror of
https://github.com/OpenVPN/openvpn3.git
synced 2024-09-19 19:52:15 +02:00
WinSvc: define virtual d'tor
The Windows Service class did not specify its destructor as virtual, but has other virtual function. Not specifying the d'tor virtual is an anti-pattern in this case. Signed-off-by: Heiko Hund <heiko@openvpn.net>
This commit is contained in:
parent
8c8e96e138
commit
f5db521aa7
@ -59,6 +59,8 @@ class Service
|
||||
checkpoint = 1;
|
||||
}
|
||||
|
||||
virtual ~Service() = default;
|
||||
|
||||
bool is_service() const
|
||||
{
|
||||
return bool(service);
|
||||
|
Loading…
Reference in New Issue
Block a user