mirror of
https://github.com/OpenVPN/openvpn3.git
synced 2024-09-20 04:02:15 +02:00
be3f20dc58
The need of having to call the assert_crypto() member function to ensure that a cryptographically strong RNG is used where needed, was reported as potentially insecure, since calling it manually can easily be missed. In the commit the two new classes StrongRandomAPI and WeakRandomAPI are introduced. They are to be used instead of just RandomAPI, unless it doesn't matter what strength the RNG is. All the places the assert_crypto() was called were converted to using StrongRandomAPI instead. Also the RNGs for which assert_crypto() was not throwing are now inheriting from StrongRandomAPI. Variable names, which have the StrongRandomAPI type, but were called prng, are changed to rng instead to follow the source code convention. Signed-off-by: Heiko Hund <heiko@openvpn.net>
142 lines
4.8 KiB
C++
142 lines
4.8 KiB
C++
// OpenVPN -- An application to securely tunnel IP networks
|
|
// over a single port, with support for SSL/TLS-based
|
|
// session authentication and key exchange,
|
|
// packet encryption, packet authentication, and
|
|
// packet compression.
|
|
//
|
|
// Copyright (C) 2012-2022 OpenVPN Inc.
|
|
//
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Affero General Public License Version 3
|
|
// as published by the Free Software Foundation.
|
|
//
|
|
// This program is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Affero General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Affero General Public License
|
|
// along with this program in the COPYING file.
|
|
|
|
#include "test_common.h"
|
|
|
|
|
|
using namespace openvpn;
|
|
|
|
#include <openvpn/ssl/sslchoose.hpp>
|
|
#include <openvpn/ssl/sslapi.hpp>
|
|
|
|
TEST(ssl, sslciphersuites)
|
|
{
|
|
SSLFactoryAPI::Ptr sslfact;
|
|
SSLLib::SSLAPI::Config::Ptr sslcfg(new SSLLib::SSLAPI::Config);
|
|
sslcfg->set_local_cert_enabled(false);
|
|
sslcfg->set_flags(SSLConst::NO_VERIFY_PEER);
|
|
|
|
sslcfg->set_tls_ciphersuite_list("TLS_CHACHA20_POLY1305_SHA256:TLS_AES_128_CCM_SHA256");
|
|
|
|
sslfact = sslcfg->new_factory();
|
|
|
|
|
|
sslcfg->set_tls_ciphersuite_list("TLS_CHACHA2000");
|
|
#if defined(USE_MBEDTLS) || OPENSSL_VERSION_NUMBER < 0x10100000L
|
|
/* Ignored on non TLS 1.3 implementations */
|
|
sslfact = sslcfg->new_factory();
|
|
#else
|
|
/* This is invalid and should throw an exception */
|
|
EXPECT_THROW(sslcfg->new_factory(), SSLFactoryAPI::ssl_context_error);
|
|
#endif
|
|
}
|
|
|
|
TEST(ssl, sslciphers)
|
|
{
|
|
StrongRandomAPI::Ptr rng(new FakeSecureRand);
|
|
|
|
bool previousLogOutput = testLog->isStdoutEnabled();
|
|
testLog->setPrintOutput(false);
|
|
SSLFactoryAPI::Ptr sslfact;
|
|
SSLLib::SSLAPI::Config::Ptr sslcfg(new SSLLib::SSLAPI::Config);
|
|
sslcfg->set_local_cert_enabled(false);
|
|
sslcfg->set_flags(SSLConst::NO_VERIFY_PEER);
|
|
sslcfg->set_rng(rng);
|
|
|
|
/* This list mixes IANA and OpenSSL ciphers to see if ciphers are translated for mbed TLS and for OpenSSL */
|
|
sslcfg->set_tls_cipher_list("TLS-ECDHE-RSA-WITH-AES-128-GCM-SHA256:TLS-ECDHE-RSA-WITH-AES-128-CBC-SHA256:AES256-SHA");
|
|
|
|
sslfact = sslcfg->new_factory();
|
|
sslfact->ssl();
|
|
|
|
testLog->setPrintOutput(previousLogOutput);
|
|
}
|
|
|
|
TEST(ssl, tls_groups)
|
|
{
|
|
StrongRandomAPI::Ptr rng(new FakeSecureRand);
|
|
|
|
SSLFactoryAPI::Ptr sslfact;
|
|
|
|
SSLLib::SSLAPI::Config::Ptr sslcfg(new SSLLib::SSLAPI::Config);
|
|
sslcfg->set_local_cert_enabled(false);
|
|
sslcfg->set_flags(SSLConst::NO_VERIFY_PEER);
|
|
sslcfg->set_rng(rng);
|
|
|
|
sslcfg->set_tls_groups("secp521r1:secp384r1");
|
|
|
|
/* Should not throw an error */
|
|
auto f = sslcfg->new_factory();
|
|
f->ssl();
|
|
|
|
sslcfg->set_tls_groups("secp521r1:secp384r1:greenhell");
|
|
|
|
|
|
testLog->startCollecting();
|
|
f = sslcfg->new_factory();
|
|
f->ssl();
|
|
#ifdef USE_OPENSSL
|
|
EXPECT_EQ("OpenSSL -- warning ignoring unknown group 'greenhell' in tls-groups\n", testLog->stopCollecting());
|
|
#else
|
|
EXPECT_EQ("mbed TLS -- warning ignoring unknown group 'greenhell' in tls-groups\n", testLog->stopCollecting());
|
|
#endif
|
|
}
|
|
|
|
#if defined(USE_OPENSSL)
|
|
TEST(ssl, translate_ciphers_openssl)
|
|
{
|
|
bool previousLogOutput = testLog->isStdoutEnabled();
|
|
testLog->setPrintOutput(false);
|
|
EXPECT_EQ("ECDHE-RSA-AES128-GCM-SHA256:ECDHE-RSA-AES128-SHA256:AES256-SHA",
|
|
OpenSSLContext::translate_cipher_list("TLS-ECDHE-RSA-WITH-AES-128-GCM-SHA256:TLS-ECDHE-RSA-WITH-AES-128-CBC-SHA256:AES256-SHA"));
|
|
EXPECT_EQ("DEFAULT", OpenSSLContext::translate_cipher_list("DEFAULT"));
|
|
EXPECT_EQ("NONSENSE:AES256-SHA", OpenSSLContext::translate_cipher_list("NONSENSE:AES256-SHA"));
|
|
|
|
testLog->setPrintOutput(previousLogOutput);
|
|
}
|
|
#endif
|
|
|
|
#if defined(USE_OPENSSL) && OPENSSL_VERSION_NUMBER >= 0x30000000L
|
|
TEST(ssl, enablelegacyProvider)
|
|
{
|
|
StrongRandomAPI::Ptr rng(new FakeSecureRand);
|
|
|
|
SSLLib::SSLAPI::Config::Ptr sslcfg(new SSLLib::SSLAPI::Config);
|
|
sslcfg->set_local_cert_enabled(false);
|
|
sslcfg->set_flags(SSLConst::NO_VERIFY_PEER);
|
|
sslcfg->set_rng(rng);
|
|
|
|
auto f_nolegacy = sslcfg->new_factory();
|
|
|
|
EXPECT_EQ(SSLLib::CryptoAPI::CipherContext::is_supported(f_nolegacy->libctx(), openvpn::CryptoAlgs::BF_CBC), false);
|
|
|
|
SSLLib::SSLAPI::Config::Ptr sslcfg_legacy(new SSLLib::SSLAPI::Config);
|
|
sslcfg_legacy->set_local_cert_enabled(false);
|
|
sslcfg_legacy->set_flags(SSLConst::NO_VERIFY_PEER);
|
|
sslcfg_legacy->set_rng(rng);
|
|
sslcfg_legacy->enable_legacy_algorithms(true);
|
|
|
|
/* Should not throw an error */
|
|
auto f_legacy = sslcfg_legacy->new_factory();
|
|
|
|
EXPECT_EQ(SSLLib::CryptoAPI::CipherContext::is_supported(f_legacy->libctx(), openvpn::CryptoAlgs::BF_CBC), true);
|
|
}
|
|
#endif
|