0
0
mirror of https://github.com/OpenVPN/openvpn3.git synced 2024-09-20 12:12:15 +02:00
openvpn3/openvpn/openssl
Arne Schwabe 8ea9b68138 Fix free in RSA external PKI, remove unused return value of EC do_sign
Errors fixed from gcc:

openvpn/openssl/pki/extpki.hpp: In static member function ‘static ECDSA_SIG* openvpn::ExternalPKIECImpl::ecdsa_sign_sig(const unsigned char*, int, const BIGNUM*, const BIGNUM*, EC_KEY*)’:
openvpn/openssl/pki/extpki.hpp:366:11: warning: variable ‘out’ set but not used [-Wunused-but-set-variable]

From Converity scan:

>>>     CID 351295:  Null pointer dereferences  (REVERSE_INULL)
>>>     Null-checking "rsa_meth" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
117     	  if (rsa_meth)
118     	    RSA_meth_free(rsa_meth);
119     	}

Remove also check from sigout.size() > siglen. The buffer will throw an
exception if the decoded bytes do not fit.
2019-12-18 17:48:50 +01:00
..
bio bio_memq_stream.hpp: fixed multi-thread race (introduced with OpenSSL 1.1 support) using init_static() approach 2019-05-16 14:50:06 +02:00
crypto openssl/cipher.hpp: add missing include <compat.hpp> 2019-08-10 13:11:25 +03:00
pki Fix free in RSA external PKI, remove unused return value of EC do_sign 2019-12-18 17:48:50 +01:00
sign OpenSSLSign: updated for OpenSSL 1.1 2019-07-17 10:53:46 -06:00
ssl [OVPN3-492] Add support for external EC certificates/keys 2019-11-27 17:58:57 +01:00
util Do not use deprecated OpenSSL 1.1.0 methods 2019-07-24 13:20:34 +02:00
compat.hpp openssl: Missing inline keyword in a couple of compat functions 2019-09-11 20:21:33 +02:00