From 6e6e4301edf64438e5912b2a84744f54d7a63bb8 Mon Sep 17 00:00:00 2001 From: David Goodwin Date: Fri, 5 Jan 2024 19:31:54 +0000 Subject: [PATCH] an empty check would catch null ... while != "" will also match null it feels wrong --- model/TotpPf.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/model/TotpPf.php b/model/TotpPf.php index 28751ec1..78b89d49 100644 --- a/model/TotpPf.php +++ b/model/TotpPf.php @@ -81,7 +81,8 @@ class TotpPf ]; $result = db_query_one($sql, $values); - if (is_array($result) && isset($result['totp_secret']) && $result['totp_secret'] != '') { + + if (is_array($result) && isset($result['totp_secret']) && !empty($result['totp_secret'])) { return true; } return false;