mirror/thunderbird-android
0
0
Fork 0
mirror of https://github.com/thunderbird/thunderbird-android.git synced 2024-09-20 04:02:14 +02:00
Code

Merge pull request #7124 from thundernest/empty_signature

Browse Source 
Don't enable signature when signature input during setup was left empty
This commit is contained in:
cketti 2023-08-14 18:33:59 +02:00 committed by GitHub
commit 599e340aab
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
feature/account/setup/src/main/kotlin/app/k9mail/feature/account/setup/ui/options/AccountOptionsStateMapper.kt
View File

@ -29,7 +29,7 @@ internal fun State.toAccountOptions(): AccountOptions {
return AccountOptions(
accountName = accountName.value,
displayName = displayName.value,
emailSignature = emailSignature.value,
emailSignature = emailSignature.value.takeIf { it.isNotEmpty() },
checkFrequencyInMinutes = checkFrequency.minutes,
messageDisplayCount = messageDisplayCount.count,
showNotification = showNotification,

10
feature/account/setup/src/test/kotlin/app/k9mail/feature/account/setup/ui/options/AccountOptionsStateMapperKtTest.kt
View File

@ -6,6 +6,7 @@ import app.k9mail.feature.account.setup.domain.entity.EmailDisplayCount
import app.k9mail.feature.account.setup.domain.input.StringInputField
import assertk.assertThat
import assertk.assertions.isEqualTo
import assertk.assertions.isNull
import org.junit.Test
class AccountOptionsStateMapperKtTest {
@ -34,4 +35,13 @@ class AccountOptionsStateMapperKtTest {
),
)
}
@Test
fun `empty signature should map to null`() {
val state = AccountOptionsContract.State(emailSignature = StringInputField(""))
val result = state.toAccountOptions()
assertThat(result.emailSignature).isNull()
}
}