diff --git a/app/core/src/main/java/com/fsck/k9/notification/NotificationHelper.kt b/app/core/src/main/java/com/fsck/k9/notification/NotificationHelper.kt index a6075a51c1..70791e3263 100644 --- a/app/core/src/main/java/com/fsck/k9/notification/NotificationHelper.kt +++ b/app/core/src/main/java/com/fsck/k9/notification/NotificationHelper.kt @@ -38,10 +38,11 @@ class NotificationHelper( try { notificationManager.notify(notificationId, notification) } catch (e: SecurityException) { - // When importing settings from another device, we could end up with a NotificationChannel that references a - // non-existing notification sound. In that case, we end up with a SecurityException with a message similar - // to this: - // UID 123 does not have permission to content://media/external_primary/audio/media/42?title=Coins&canonical=1 [user 0] + // When importing settings from another device, we could end up with a NotificationChannel that references + // a non-existing notification sound. In that case, we end up with a SecurityException with a message + // similar to this: + // UID 123 does not have permission to + // content://media/external_primary/audio/media/42?title=Coins&canonical=1 [user 0] if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O && e.message?.contains("does not have permission to") == true ) { diff --git a/app/ui/legacy/src/main/java/com/fsck/k9/ui/messageview/MessageViewFragment.kt b/app/ui/legacy/src/main/java/com/fsck/k9/ui/messageview/MessageViewFragment.kt index efc2931ebe..b7af7ac50f 100644 --- a/app/ui/legacy/src/main/java/com/fsck/k9/ui/messageview/MessageViewFragment.kt +++ b/app/ui/legacy/src/main/java/com/fsck/k9/ui/messageview/MessageViewFragment.kt @@ -198,8 +198,8 @@ class MessageViewFragment : if (menuVisible) { messageLoaderHelper.resumeCryptoOperationIfNecessary() } else { - // When the menu is hidden, the message associated with this fragment is no longer active. If the user returns - // to it, we want to mark the message as opened again. + // When the menu is hidden, the message associated with this fragment is no longer active. If the user + // returns to it, we want to mark the message as opened again. wasMessageMarkedAsOpened = false } } diff --git a/config/detekt/detekt-baseline-app-core.xml b/config/detekt/detekt-baseline-app-core.xml index 3c270a4d5d..5aeacc0b94 100644 --- a/config/detekt/detekt-baseline-app-core.xml +++ b/config/detekt/detekt-baseline-app-core.xml @@ -84,8 +84,6 @@ MagicNumber:ServerSettingsSerializer.kt$ServerSettingsAdapter$7 MagicNumber:SettingsExporter.kt$SettingsExporter$3 MagicNumber:TimberLogger.kt$TimberLogger$26 - MaxLineLength:GenericUriParserTest.kt$GenericUriParserTest$assertUriValid("xmpp:node@example.com/repulsive%20!%23%22\$%25&'()*+,-.%2F:;%3C=%3E%3F%40%5B%5C%5D%5E_%60%7B%7C%7D~resource") - MaxLineLength:NotificationHelper.kt$NotificationHelper$// UID 123 does not have permission to content://media/external_primary/audio/media/42?title=Coins&canonical=1 [user 0] MayBeConst:SummaryNotificationDataCreatorTest.kt$private val TIMESTAMP = 0L MemberNameEqualsClassName:HtmlModification.kt$HtmlModification.Replace$abstract fun replace(textToHtml: TextToHtml) NestedBlockDepth:HttpUriParser.kt$HttpUriParser$private fun tryMatchIpv6Address(text: CharSequence, startPos: Int): Int diff --git a/config/detekt/detekt-baseline-app-storage.xml b/config/detekt/detekt-baseline-app-storage.xml index 5f5116ac09..66da340b59 100644 --- a/config/detekt/detekt-baseline-app-storage.xml +++ b/config/detekt/detekt-baseline-app-storage.xml @@ -103,8 +103,6 @@ MagicNumber:StorageMigrationTo17.kt$StorageMigrationTo17$0xFFFF00 MagicNumber:StorageMigrationTo17.kt$StorageMigrationTo17$0xFFFFFF MagicNumber:ThreadMessageOperations.kt$ThreadMessageOperations$3 - MaxLineLength:MigrationTo70.kt$MigrationTo70$db.execSQL("CREATE TRIGGER delete_folder BEFORE DELETE ON folders BEGIN DELETE FROM messages WHERE old.id = folder_id; END;") - MaxLineLength:MigrationTo84.kt$MigrationTo84$"SELECT id, to_list, cc_list, bcc_list, reply_to_list, sender_list FROM messages WHERE empty = 0 AND deleted = 0" MaxLineLength:RetrieveMessageListOperationsTest.kt$RetrieveMessageListOperationsTest$fun ReturnCount:SaveMessageOperationsTest.kt$SaveMessageOperationsTest$private fun Message.getDownloadState(): MessageDownloadState ReturnCount:StorageMigrationTo19.kt$StorageMigrationTo19$private fun markIfGmailAccount(accountUuid: String) diff --git a/config/detekt/detekt-baseline-app-ui-legacy.xml b/config/detekt/detekt-baseline-app-ui-legacy.xml index e474d742a4..731859edb3 100644 --- a/config/detekt/detekt-baseline-app-ui-legacy.xml +++ b/config/detekt/detekt-baseline-app-ui-legacy.xml @@ -82,14 +82,10 @@ MagicNumber:SizeFormatter.kt$SizeFormatter$1_000_000L MagicNumber:SizeFormatter.kt$SizeFormatter$999_950L MagicNumber:SizeFormatter.kt$SizeFormatter$999_950_000L - MaxLineLength:ComposeCryptoStatus.kt$ComposeCryptoStatus$OpenPgpApiManager.OpenPgpProviderState.ERROR, OpenPgpApiManager.OpenPgpProviderState.UI_REQUIRED -> CryptoStatusDisplayType.ERROR - MaxLineLength:MessageViewFragment.kt$MessageViewFragment$// When the menu is hidden, the message associated with this fragment is no longer active. If the user returns MemberNameEqualsClassName:ReplyToView.kt$ReplyToView$private val replyToView: RecipientSelectView = activity.findViewById(R.id.reply_to) NestedBlockDepth:MessageList.kt$MessageList$override fun onBackPressed() NestedBlockDepth:MessageList.kt$MessageList$override fun onOptionsItemSelected(item: MenuItem): Boolean NestedBlockDepth:MessageList.kt$MessageList$private fun decodeExtrasToLaunchData(intent: Intent): LaunchData - ReturnCount:AccountSetupBasics.kt$AccountSetupBasics$private fun providersXmlDiscoveryDiscover(email: String): ConnectionSettings? - ReturnCount:AccountSetupBasics.kt$private fun DiscoveredServerSettings.toServerSettings(): ServerSettings? ReturnCount:AccountSetupCheckSettings.kt$AccountSetupCheckSettings.CheckAccountTask$private fun isCanceled(): Boolean ReturnCount:ChooseFolderActivity.kt$ChooseFolderActivity$private fun decodeArguments(savedInstanceState: Bundle?): Boolean ReturnCount:EditIdentity.kt$EditIdentity$override fun onOptionsItemSelected(item: MenuItem): Boolean @@ -162,7 +158,6 @@ TooGenericExceptionThrown:MessageViewFragment.kt$MessageViewFragment$throw RuntimeException("Called showDialog(int) with unknown dialog id.") TooManyFunctions:AccountSettingsDataStore.kt$AccountSettingsDataStore : PreferenceDataStore TooManyFunctions:AccountSettingsFragment.kt$AccountSettingsFragment : PreferenceFragmentCompatConfirmationDialogFragmentListener - TooManyFunctions:AccountSetupBasics.kt$AccountSetupBasics : K9Activity TooManyFunctions:AccountSetupCheckSettings.kt$AccountSetupCheckSettings : K9ActivityConfirmationDialogFragmentListener TooManyFunctions:AuthViewModel.kt$AuthViewModel : AndroidViewModel TooManyFunctions:AutocryptKeyTransferActivity.kt$AutocryptKeyTransferActivity : K9Activity diff --git a/config/detekt/detekt-baseline-backend-jmap.xml b/config/detekt/detekt-baseline-backend-jmap.xml index f18f71ace9..d346c12bd1 100644 --- a/config/detekt/detekt-baseline-backend-jmap.xml +++ b/config/detekt/detekt-baseline-backend-jmap.xml @@ -3,7 +3,6 @@ ForbiddenComment:CommandSync.kt$CommandSync$// FIXME: Add sort parameter - MaxLineLength:JmapBackend.kt$JmapBackend$override ReturnCount:JmapAccountDiscovery.kt$JmapAccountDiscovery$fun discover(emailAddress: String, password: String): JmapDiscoveryResult SwallowedException:JmapAccountDiscovery.kt$JmapAccountDiscovery$e: EndpointNotFoundException SwallowedException:JmapAccountDiscovery.kt$JmapAccountDiscovery$e: UnauthorizedException diff --git a/config/detekt/detekt-baseline-mail-common.xml b/config/detekt/detekt-baseline-mail-common.xml index 5a365642a5..2f5d4fe9bb 100644 --- a/config/detekt/detekt-baseline-mail-common.xml +++ b/config/detekt/detekt-baseline-mail-common.xml @@ -51,7 +51,6 @@ MagicNumber:Utf8.kt$3 MagicNumber:Utf8.kt$4 MagicNumber:Utf8.kt$6 - MaxLineLength:BoundaryGeneratorTest.kt$BoundaryGeneratorTest$0 ReturnCount:DecoderUtil.kt$DecoderUtil$@JvmStatic fun decodeEncodedWords(body: String, message: Message?): String ReturnCount:DecoderUtil.kt$DecoderUtil$private fun extractEncodedWord(body: String, begin: Int, end: Int, message: Message?): EncodedWord? ReturnCount:FormatFlowedHelper.kt$FormatFlowedHelper$@JvmStatic fun checkFormatFlowed(contentTypeHeaderValue: String?): FormatFlowedResult diff --git a/config/detekt/detekt-baseline-mail-protocols-imap.xml b/config/detekt/detekt-baseline-mail-protocols-imap.xml index 3c75575048..ac9ca7582d 100644 --- a/config/detekt/detekt-baseline-mail-protocols-imap.xml +++ b/config/detekt/detekt-baseline-mail-protocols-imap.xml @@ -39,7 +39,6 @@ MagicNumber:RealImapFolder.kt$RealImapFolder$9 MagicNumber:UidValidityResponse.kt$UidValidityResponse.Companion$0xFFFFFFFFL MaxLineLength:RealImapFolder.kt$RealImapFolder$// [MESSAGE, RFC822, [NAME, Fwd: [#HTR-517941]: update plans at 1am Friday - Memory allocation - displayware.eml], NIL, NIL, 7BIT, 5974, NIL, [INLINE, [FILENAME*0, Fwd: [#HTR-517941]: update plans at 1am Friday - Memory all, FILENAME*1, ocation - displayware.eml]], NIL] - MaxLineLength:RealImapFolder.kt$RealImapFolder$val canCreateForwardedFlag = canCreateKeywords || internalImapStore.getPermanentFlagsIndex().contains(Flag.FORWARDED) MaxLineLength:RealImapStoreTest.kt$RealImapStoreTest$fun NestedBlockDepth:RealImapFolder.kt$RealImapFolder$@Throws(MessagingException::class) override fun appendMessages(messages: List<Message>): Map<String, String>? NestedBlockDepth:RealImapFolder.kt$RealImapFolder$@Throws(MessagingException::class) override fun fetch( messages: List<ImapMessage>, fetchProfile: FetchProfile, listener: FetchListener?, maxDownloadSize: Int, )