mirror/thunderbird-android
0
0
Fork 0
mirror of https://github.com/thunderbird/thunderbird-android.git synced 2024-09-20 12:12:15 +02:00
Code

Merge pull request #6828 from thundernest/log_export_exceptions

Browse Source 
Log exception when exporting settings to a file fails
This commit is contained in:
cketti 2023-04-18 14:59:50 +02:00 committed by GitHub
commit 7d429d565b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
app/ui/legacy/src/main/java/com/fsck/k9/ui/settings/export/SettingsExportViewModel.kt
View File

@ -10,6 +10,7 @@ import androidx.lifecycle.viewModelScope
import com.fsck.k9.Preferences
import com.fsck.k9.helper.SingleLiveEvent
import com.fsck.k9.helper.measureRealtimeMillis
import com.fsck.k9.logging.Timber
import com.fsck.k9.preferences.SettingsExporter
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.delay
@ -146,6 +147,8 @@ class SettingsExportViewModel(
showSuccessText()
}
} catch (e: Exception) {
Timber.e(e, "Error writing settings file")
updateUiModel {
showFailureText()
}

2
config/detekt/baseline.xml
View File

@ -638,7 +638,6 @@
<ID>SwallowedException:RealImapStore.kt$RealImapStore$e: CharacterCodingException</ID>
<ID>SwallowedException:RealImapStore.kt$RealImapStore$ioe: IOException</ID>
<ID>SwallowedException:SaveMessageOperations.kt$SaveMessageOperations$e: IOException</ID>
<ID>SwallowedException:SettingsExportViewModel.kt$SettingsExportViewModel$e: Exception</ID>
<ID>SwallowedException:SettingsExporter.kt$SettingsExporter$e: InvalidSettingValueException</ID>
<ID>SwallowedException:SettingsListFragment.kt$SettingsListFragment$e: ActivityNotFoundException</ID>
<ID>SwallowedException:SmtpTransport.kt$SmtpTransport$e: NegativeSmtpReplyException</ID>
@ -802,7 +801,6 @@
<ID>UnusedPrivateMember:HttpUriParser.kt$HttpUriParser$i</ID>
<ID>UnusedPrivateMember:MessageListLoader.kt$MessageListLoader$account: Account</ID>
<ID>UnusedPrivateMember:MessageViewFragment.kt$MessageViewFragment$requestKey: String</ID>
<ID>UnusedPrivateMember:NewSetupUiHack.kt$NewSetupUiHack$builder: SettingsListBuilder</ID>
<ID>UseCheckOrError:OutboxStateRepository.kt$OutboxStateRepository$throw IllegalStateException("No outbox_state entry for message with id $messageId")</ID>
<ID>UseCheckOrError:ThemeExtensions.kt$throw IllegalStateException("Couldn't resolve attribute ($attrId)")</ID>
<ID>UseRequire:MimeParameterEncoder.kt$MimeParameterEncoder$throw IllegalArgumentException("Unsupported character: $c")</ID>