mirror/thunderbird-android
0
0
Fork 0
mirror of https://github.com/thunderbird/thunderbird-android.git synced 2024-09-20 04:02:14 +02:00
Code

Don't call open() from RealImapFolder.appendMessages()

Browse Source
This commit is contained in:
cketti 2024-04-25 21:39:07 +02:00
parent 874b06f415
commit 94e0ced621
2 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/RealImapFolder.kt
View File

@ -964,7 +964,6 @@ internal class RealImapFolder(
*/ */
@Throws(MessagingException::class) @Throws(MessagingException::class)
override fun appendMessages(messages: List<Message>): Map<String, String>? { override fun appendMessages(messages: List<Message>): Map<String, String>? {
open(OpenMode.READ_WRITE)
checkOpen() checkOpen()
return try { return try {

13
mail/protocols/imap/src/test/java/com/fsck/k9/mail/store/imap/RealImapFolderTest.kt
View File

@ -994,6 +994,19 @@ class RealImapFolderTest {
assertThat(buffer.readUtf8()).isEqualTo("text") assertThat(buffer.readUtf8()).isEqualTo("text")
} }
@Test
fun `appendMessages() on closed folder should throw`() {
val folder = createFolder("Folder")
val messages = listOf(createImapMessage("1"))
assertFailure {
folder.appendMessages(messages)
}.isInstanceOf<MessagingException>()
.hasMessage("Folder Folder is not open.")
verifyNoMoreInteractions(imapConnection)
}
@Test @Test
fun appendMessages_shouldIssueRespectiveCommand() { fun appendMessages_shouldIssueRespectiveCommand() {
val folder = createFolder("Folder") val folder = createFolder("Folder")