mirror/thunderbird-android
0
0
Fork 0
mirror of https://github.com/thunderbird/thunderbird-android.git synced 2024-09-19 19:52:14 +02:00
Code

Merge pull request #7991 from thunderbird/update_comment

Browse Source 
Update comment for `ForegroundServiceStartNotAllowedException` workaround
This commit is contained in:
cketti 2024-06-28 11:21:16 +02:00 committed by GitHub
commit f1b90080f9
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
app/core/src/main/java/com/fsck/k9/controller/push/PushService.kt
View File

@ -56,19 +56,8 @@ class PushService : Service() {
} catch (e: ForegroundServiceStartNotAllowedException) {
Timber.e(e, "Ignoring ForegroundServiceStartNotAllowedException during automatic restart.")
// There are quite a few crash reports where calling startForeground() throws
// ForegroundServiceStartNotAllowedException when the system is restarting the service. This shouldn't
// happen since the app was allowed to start a foreground service when it was originally started.
// We haven't been able to reliably reproduce this behavior. So it's not clear if and how we can work
// around this.
//
// Possible workarounds:
// - [X] Catch and ignore ForegroundServiceStartNotAllowedException.
// - [ ] Skip call to startForeground() when onStartCommand() is called with intent == null.
// - [ ] Catch ForegroundServiceStartNotAllowedException and stop the service. Create a notification
// asking the user to tap it to restart the push service.
//
// See https://github.com/thunderbird/thunderbird-android/issues/7416
// This works around what seems to be a bug in at least Android 14.
// See https://github.com/thunderbird/thunderbird-android/issues/7416 for more details.
}
}
}